Implement new rule ImplictUnitReturnTypet #2781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturbosch
force-pushed
the
new-rule-prefer-block-statement-for-unit
branch
2 times, most recently
from
11a8c4b to
135cdba
Compare
arturbosch
changed the title
arturbosch
commented
Jun 8, 2020
...ules/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/ExpressionFunctionReturnsUnit.kt
Outdated
Show resolved
Hide resolved
arturbosch
commented
Jun 8, 2020
...ules/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/ExpressionFunctionReturnsUnit.kt
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #2781 +/- ##
============================================
+ Coverage 80.52% 80.64% +0.11%
- Complexity 2335 2350 +15
============================================
Files 387 388 +1
Lines 6993 7026 +33
Branches 1269 1281 +12
============================================
+ Hits 5631 5666 +35
+ Misses 726 716 -10
- Partials 636 644 +8
Continue to review full report at Codecov.
|
cortinico
requested changes
Jun 8, 2020
...ules/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/ExpressionFunctionReturnsUnit.kt
Outdated
Show resolved
Hide resolved
...ules/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/ExpressionFunctionReturnsUnit.kt
Outdated
Show resolved
Hide resolved
...ules/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/ExpressionFunctionReturnsUnit.kt
Outdated
Show resolved
Hide resolved
...ules/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/ExpressionFunctionReturnsUnit.kt
Outdated
Show resolved
Hide resolved
...ules/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/ExpressionFunctionReturnsUnit.kt
Outdated
Show resolved
Hide resolved
...ules/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/ExpressionFunctionReturnsUnit.kt
Outdated
Show resolved
Hide resolved
...ules/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/ExpressionFunctionReturnsUnit.kt
Outdated
Show resolved
Hide resolved
arturbosch
force-pushed
the
new-rule-prefer-block-statement-for-unit
branch
from
e2e136d to
cf4b7d3
Compare
BraisGabin
reviewed
Jun 21, 2020
...t-rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/ImplicitUnitReturnTypeSpec.kt
Outdated
Show resolved
Hide resolved
BraisGabin
approved these changes
Jun 21, 2020
cortinico
approved these changes
Jun 22, 2020
...t-rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/ImplicitUnitReturnTypeSpec.kt
Outdated
Show resolved
Hide resolved
...t-rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/ImplicitUnitReturnTypeSpec.kt
Outdated
Show resolved
Hide resolved
…/bugs/ImplicitUnitReturnTypeSpec.kt Co-authored-by: Nicola Corti <corti.nico@gmail.com>
…/bugs/ImplicitUnitReturnTypeSpec.kt Co-authored-by: Nicola Corti <corti.nico@gmail.com>
arturbosch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule suggests to use block statements for functions when the return type is of type Unit.