Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce BoM to manage our own dependencies #2792

Merged
merged 4 commits into from
Jun 13, 2020
Merged

Conversation

BraisGabin
Copy link
Member

Right now this Bill of Materials (BoM) module just manage our dependencies. We could expose it so our users can align it's dependencies easier too. If we want to do that we should iterate this file a bit more.

After this change the file buildSrc/Versions.kt seems kind of pointless. I think that we should be able to move all those consts to better places.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait and see what others think about this change.

@cortinico
Copy link
Member

After this change the file buildSrc/Versions.kt seems kind of pointless. I think that we should be able to move all those consts to better places.

Nice addition.
On this side, agree that we can get rid of that file. Therefore, we should update #2788 to use detekt-bom/build.gradle.kts as cache key.

@BraisGabin
Copy link
Member Author

Therefore, we should update #2788 to use detekt-bom/build.gradle.kts as cache key.

It was that pr that made me think about this.

@arturbosch arturbosch added this to the 1.10.0 milestone Jun 13, 2020
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Jun 13, 2020
@arturbosch arturbosch merged commit befe272 into detekt:master Jun 13, 2020
@realdadfish
Copy link
Contributor

realdadfish commented Jun 15, 2020

I think this change broke at least maven-local publishing. The POM of the Gradle plugin lists detekt-bom in it's dependencies, but since detekt-bom is not published, it fails to resolve this dependency:

<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <!-- This module was also published with a richer model, Gradle metadata,  -->
  <!-- which should be used instead. Do not delete the following line which  -->
  <!-- is to indicate to Gradle or any Gradle module metadata file consumer  -->
  <!-- that they should prefer consuming it instead. -->
  <!-- do_not_remove: published-with-gradle-metadata -->
  <modelVersion>4.0.0</modelVersion>
  <groupId>io.gitlab.arturbosch.detekt</groupId>
  <artifactId>detekt-gradle-plugin</artifactId>
  <version>1.10.0-RC1-android-gradle-plugin</version>
  <dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>io.gitlab.arturbosch.detekt</groupId>
        <artifactId>detekt-bom</artifactId>
        <version>1.10.0-RC1-android-gradle-plugin</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>
    </dependencies>
  </dependencyManagement>
  <dependencies>
    <dependency>
      <groupId>org.jetbrains.kotlin</groupId>
      <artifactId>kotlin-gradle-plugin</artifactId>
      <version>1.3.72</version>
      <scope>runtime</scope>
    </dependency>
    <dependency>
      <groupId>org.jetbrains.kotlin</groupId>
      <artifactId>kotlin-gradle-plugin-api</artifactId>
      <version>1.3.72</version>
      <scope>runtime</scope>
    </dependency>
  </dependencies>
</project>

@realdadfish
Copy link
Contributor

Hrm... ok, the Bintray publishing does not contain a reference to detekt-bom. Very weird: https://search.maven.org/artifact/io.gitlab.arturbosch.detekt/detekt-gradle-plugin/1.10.0-RC1/jar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants