Skip to content

Fix false positive for UnusedPrivateClass on generics - #2793

Merged
schalkms merged 2 commits into
detekt:masterfrom
cortinico:nc/#2791/false-pos-unused-private-class
Jun 12, 2020
Merged

schalkms merged 2 commits into
detekt:masterfrom
cortinico:nc/#2791/false-pos-unused-private-class

Conversation

@cortinico

Copy link
Copy Markdown
Member

Covered the scenario for more complex type parameters. I've also added a couple of tests.

Fixes #2791

@codecov

codecov Bot commented Jun 12, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #2793 into master will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2793      +/-   ##
============================================
- Coverage     80.53%   80.51%   -0.02%     
  Complexity     2324     2324              
============================================
  Files           386      386              
  Lines          6955     6955              
  Branches       1261     1262       +1     
============================================
- Hits           5601     5600       -1     
  Misses          725      725              
- Partials        629      630       +1     
Impacted Files Coverage Δ Complexity Δ
...rturbosch/detekt/rules/style/UnusedPrivateClass.kt 67.21% <50.00%> (-1.64%) 4.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e71275...128e95a. Read the comment docs.

@schalkms
schalkms merged commit ae9f7ce into detekt:master Jun 12, 2020
@arturbosch arturbosch added this to the 1.10.0 milestone Jun 13, 2020
@cortinico
cortinico deleted the nc/#2791/false-pos-unused-private-class branch June 13, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UnusedPrivateClass - false positive for deserialization

3 participants