-
-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run compile-test-snippets in a isolated job #2797
Run compile-test-snippets in a isolated job #2797
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2797 +/- ##
============================================
+ Coverage 80.51% 80.53% +0.01%
- Complexity 2324 2326 +2
============================================
Files 386 386
Lines 6955 6957 +2
Branches 1262 1262
============================================
+ Hits 5600 5603 +3
Misses 725 725
+ Partials 630 629 -1
Continue to review full report at Codecov.
|
And as a opne question, should we use java 8 as the default version? Maybe we should use the last java version (14). I was the one that add the compilation in java8 the first time. My reasoning was that, in travis, ubuntu/java8 was the fastest build (and because I'm an Android developer and the newest Java version known by an Android dev is Java8 :P). Is java8 faster? It should not... |
I've seen some benchmarks where jdk13+ started to reach jdk8 performance. jdk9 had some regressions etc. |
True story 😅 |
Turns out that on Java 14 we have more failures. I suggest we bump the Java version for |
What? Does this task fail with Java 14? That's strange. But sure, we can merge this for now. |
Yes, I was also able to reproduce the same failure on my local env. Here the log https://github.com/detekt/detekt/runs/770662663 Failing Tests
|
Oh, I saw this issue before: google/dagger#1449 We should change that annotation. But that could be done in other PR. |
Similarly to what was done in #2796, I'm extracting a job for
compile-test-snippets
only. That's our biggest bottleneck at the moment.This job (
compile-test-snippets
) will run in parallel with the others and should speedup the whole CI, given that we don't rundetekt-cli
on this job but just./gradlew build -Pcompile-test-snippets=true
.Moreover, this should provide a better hint for contributors on what's the failure of their build (i.e. they don't need to know that we compile snippets only on ubuntu-latest + java8 to understand what failed).