Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup MayBeConst tests #2802

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

cortinico
Copy link
Member

Since we touched MayBeConst in #2799, let's cleanup the tests a bit:

  • Removed old resource file
  • Switched all the lint to compileAndLint
  • Fixed several compilation failures we had
  • Adding asserts on SourceLocations

@cortinico cortinico changed the title Cleaup MayBeConst tests Cleanup MayBeConst tests Jun 14, 2020
@codecov
Copy link

codecov bot commented Jun 14, 2020

Codecov Report

Merging #2802 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2802      +/-   ##
============================================
- Coverage     80.53%   80.52%   -0.02%     
+ Complexity     2326     2323       -3     
============================================
  Files           386      386              
  Lines          6957     6957              
  Branches       1262     1262              
============================================
- Hits           5603     5602       -1     
- Misses          725      726       +1     
  Partials        629      629              
Impacted Files Coverage Δ Complexity Δ
...gitlab/arturbosch/detekt/rules/style/MayBeConst.kt 78.00% <0.00%> (-2.00%) 39.00% <0.00%> (-3.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0256975...08cc2e7. Read the comment docs.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this tedious work!

@schalkms schalkms merged commit c0f6c59 into detekt:master Jun 15, 2020
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Jun 16, 2020
@arturbosch arturbosch added this to the 1.10.0 milestone Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants