Skip to content

LongMethod: disregard params in method definition#2806

Merged
schalkms merged 8 commits into
detekt:masterfrom
niraj8:master
Jun 22, 2020
Merged

LongMethod: disregard params in method definition#2806
schalkms merged 8 commits into
detekt:masterfrom
niraj8:master

Conversation

@niraj8

@niraj8 niraj8 commented Jun 16, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #2804

@niraj8 niraj8 mentioned this pull request Jun 16, 2020
Closed
schalkms
schalkms reviewed Jun 16, 2020
View reviewed changes
Comment thread detekt-rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/LongMethodSpec.kt Outdated
Comment thread detekt-rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/LongMethodSpec.kt Outdated
@niraj8 niraj8 changed the title failing tests for #2804 LongMethod with params LongMethod: disregard params in method definition Jun 16, 2020
@niraj8 niraj8 marked this pull request as ready for review June 16, 2020 20:43
@codecov

codecov Bot commented Jun 16, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2806 into master will increase coverage by 0.00%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2806   +/-   ##
=========================================
  Coverage     80.52%   80.53%           
- Complexity     2323     2339   +16     
=========================================
  Files           386      387    +1     
  Lines          6957     6996   +39     
  Branches       1262     1271    +9     
=========================================
+ Hits           5602     5634   +32     
  Misses          726      726           
- Partials        629      636    +7
Impacted Files Coverage Δ Complexity Δ
...b/arturbosch/detekt/rules/complexity/LongMethod.kt 88.63% <76.92%> (-5.65%) 16.00 <11.00> (+4.00) ⬇️
...arturbosch/detekt/rules/naming/IsPropertyNaming.kt 85.18% <0.00%> (ø) 12.00% <0.00%> (?%)
...tlab/arturbosch/detekt/rules/naming/NamingRules.kt 93.33% <0.00%> (+0.35%) 18.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e07d5e...8536e84. Read the comment docs.

@arturbosch arturbosch added this to the 1.10.0 milestone Jun 16, 2020
arturbosch
arturbosch requested changes Jun 16, 2020
View reviewed changes

@arturbosch arturbosch left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for awesome first contribution! Please see my comment below.

Comment thread detekt-metrics/src/main/kotlin/io/github/detekt/metrics/LinesOfCode.kt Outdated
@niraj8
[ci ckip] use fun body for LongMethod
5d6d16c 
- revert changes in LinesOfCode.kt
- still need to update nested methods
niraj8
niraj8 commented Jun 18, 2020
View reviewed changes
Comment thread detekt-rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/LongMethodSpec.kt Outdated
cortinico
cortinico requested changes Jun 20, 2020
View reviewed changes
Comment thread detekt-rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/LongMethodSpec.kt Outdated
Comment thread detekt-rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/LongMethodSpec.kt Outdated
@schalkms schalkms merged commit e040704 into detekt:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schalkms schalkms schalkms left review comments
@cortinico cortinico cortinico approved these changes
@arturbosch arturbosch arturbosch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.10.0

Development

Successfully merging this pull request may close these issues.

LongMethod should not consider parameters while calculating the number of lines

4 participants

@niraj8 @cortinico @arturbosch @schalkms