UnusedPrivateClass: don't report imported classes

[t-kameyama]

Fixes #2809

[codecov]

Codecov Report

Merging #2812 into master will increase coverage by 0.00%.
The diff coverage is 57.14%.

@@            Coverage Diff            @@
##             master    #2812   +/-   ##
=========================================
  Coverage     80.52%   80.52%           
- Complexity     2323     2335   +12     
=========================================
  Files           386      387    +1     
  Lines          6957     6993   +36     
  Branches       1262     1269    +7     
=========================================
+ Hits           5602     5631   +29     
  Misses          726      726           
- Partials        629      636    +7     

Impacted Files	Coverage Δ	Complexity Δ
...rturbosch/detekt/rules/style/UnusedPrivateClass.kt	65.67% <57.14%> (-1.55%)	4.00 <0.00> (ø)
...arturbosch/detekt/rules/naming/IsPropertyNaming.kt	85.18% <0.00%> (ø)	12.00% <0.00%> (?%)
...tlab/arturbosch/detekt/rules/naming/NamingRules.kt	93.33% <0.00%> (+0.35%)	18.00% <0.00%> (ø%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0649ece...e953cdd. Read the comment docs.

[arturbosch]

Thanks!

[schalkms]

Thanks for the fix! Looks good!

[TWiStErRob]

@t-kameyama @arturbosch @schalkms isn't this a counter-example for startsWith?

import foo.bar.Baz
import foo.bar.Bazinga
fun f() {
    Baz()
}

IRL Bazinga could be generated Baz_Factory for example.

[TWiStErRob]

oh, it's only about private classes..., but there must be a similar example for that too.
e.g. a private class was renamed, but the original import not removed, but detekt wouldn't find it?

[arturbosch]

Hm, the import must start with the fully qualified name of the private class not the other way. So this should be okay?
I'm not sure if I understand your example.

package foo.bar
                import foo.bar.Baz
                import foo.bar.Bazinga
                private class BazFactory

[t-kameyama]

False negative:

package com.example

import com.example.C.EFG.EFG1

class C {
    fun test() {
        println(EFG1)
    }

    private enum class E { // false negative
        E1
    }

    private enum class EFG {
        EFG1
    }
}

[TWiStErRob]

Yep, that's what I meant.

Also be careful with nested classes inside nested classes, they might be broken now or after a fix of the false negative too.