Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify pre-merge.yaml #2823

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Simplify pre-merge.yaml #2823

merged 1 commit into from
Jun 29, 2020

Conversation

BraisGabin
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 28, 2020

Codecov Report

Merging #2823 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2823   +/-   ##
=========================================
  Coverage     80.62%   80.62%           
  Complexity     2350     2350           
=========================================
  Files           388      388           
  Lines          7025     7025           
  Branches       1282     1282           
=========================================
  Hits           5664     5664           
  Misses          717      717           
  Partials        644      644

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e3d83a...8efb9c1. Read the comment docs.

@BraisGabin BraisGabin changed the title [WIP] Simplify pre-merge.yaml Simplify pre-merge.yaml Jun 28, 2020
@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label Jun 28, 2020
arturbosch
arturbosch approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@arturbosch arturbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, so JDK has no problems with unix paths on Windows?

@arturbosch arturbosch added this to the 1.11.0 milestone Jun 29, 2020
@arturbosch arturbosch merged commit 14d6dae into detekt:master Jun 29, 2020
@BraisGabin
Copy link
Member Author

I think that Windows doesn't have problems with UNIX paths. It's default is \ but it understand / too.

@arturbosch arturbosch modified the milestones: 1.11.0, 1.10.1 Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico left review comments

@arturbosch arturbosch arturbosch approved these changes

Assignees
No one assigned
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Milestone
1.11.0-RC1
Development

Successfully merging this pull request may close these issues.
3 participants
@BraisGabin @cortinico @arturbosch