Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up generateDocumentation #2832

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Speed up generateDocumentation #2832

merged 1 commit into from
Jul 14, 2020

Conversation

BraisGabin
Copy link
Member

We don't need to run the tests of :detekt-generator or run detekt on it to just generate the documentation.

@codecov
Copy link

codecov bot commented Jun 28, 2020

Codecov Report

Merging #2832 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2832   +/-   ##
=========================================
  Coverage     80.78%   80.78%           
  Complexity     2346     2346           
=========================================
  Files           388      388           
  Lines          7050     7050           
  Branches       1288     1288           
=========================================
  Hits           5695     5695           
  Misses          709      709           
  Partials        646      646           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 265b217...b37f26b. Read the comment docs.

@BraisGabin
Copy link
Member Author

This is strange. When I builded detekt some times in different ways this change works. But it doesn't work after a clean.

I'm getting this error in my end:

> Task :detekt-generator:generateDocumentation FAILED
Exception in thread "main" java.lang.NoClassDefFoundError: io/github/detekt/parser/KtCompiler
        at io.gitlab.arturbosch.detekt.generator.Generator.execute(Generator.kt:27)
        at io.gitlab.arturbosch.detekt.generator.Main.main(Main.kt:23)
Caused by: java.lang.ClassNotFoundException: io.github.detekt.parser.KtCompiler
        at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
        at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
        ... 2 more

@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label Jun 28, 2020
@arturbosch
Copy link
Member

Could you try changing

classpath(configurations.runtimeClasspath.get(), sourceSets.main.get().output)

to compileClasspath?

@BraisGabin
Copy link
Member Author

Could you try changing

classpath(configurations.runtimeClasspath.get(), sourceSets.main.get().output)

to compileClasspath?

Changing didn't work, but adding it works in my end at least... But I'm not really sure what I was doing there.

@arturbosch
Copy link
Member

It works on CI too, just the MaxLineLength issue left ;D

@arturbosch arturbosch added this to the 1.10.1 milestone Jul 14, 2020
@BraisGabin
Copy link
Member Author

It should work now.

@arturbosch arturbosch merged commit acd36fe into detekt:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants