Simplify internal parsing to KtFile's

[arturbosch]

No description provided.

[codecov]

Codecov Report

Merging #2875 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #2875      +/-   ##
============================================
- Coverage     80.28%   80.24%   -0.04%     
+ Complexity     2417     2414       -3     
============================================
  Files           421      421              
  Lines          7359     7356       -3     
  Branches       1346     1345       -1     
============================================
- Hits           5908     5903       -5     
  Misses          756      756              
- Partials        695      697       +2     

Impacted Files	Coverage Δ	Complexity Δ
.../main/kotlin/io/github/detekt/parser/KtCompiler.kt	86.95% <100.00%> (-5.36%)	7.00 <1.00> (-2.00)
...lab/arturbosch/detekt/formatting/FormattingRule.kt	89.65% <0.00%> (-3.45%)	12.00% <0.00%> (-1.00%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 828d65d...27b5417. Read the comment docs.

[schalkms]

Is this a behavioral change now, since you had to adapt the test case?

[arturbosch]

Hm, yes it is. Not sure how to handle this.
In KtTreeCompiler we throw an exception if the file ending is not kt or kts.

In the old implementation the PsiFactory tried to use Language.Any and because no language was registered was .css it didn't tried to parse anything and returned null which we checked with error(...).
The KtPsiFactory always tries to parse Kotlin and returns a PsiFile with errors.

@schalkms @BraisGabin @cortinico should we throw an error on wrong file extension like when parsing directories?

detekt/detekt-core/src/main/kotlin/io/gitlab/arturbosch/detekt/core/KtTreeCompiler.kt

Lines 54 to 58 in 5a0fe62

	private fun Path.isKotlinFile(): Boolean {
	val fullPath = toAbsolutePath().toString()
	val kotlinEnding = fullPath.substring(fullPath.lastIndexOf('.') + 1)
	return kotlinEnding in KT_ENDINGS
	}

[arturbosch]

Ok, we ignored it when parsing many files:

detekt/detekt-core/src/main/kotlin/io/gitlab/arturbosch/detekt/core/KtTreeCompiler.kt

Line 31 in 5a0fe62

settings.info("Ignoring a file detekt cannot handle: $path")