Check string arguments with TR enabled#2879
Conversation
Check simple string arguments even when type resolution is enabled. This prevented the `UseRequire` and `UseCheckOrError` checks find issues with TR enabled.
|
I'm not sure if / where this has to be described to get picked up by the changelog, or is this done automatically? Or should this just be merged? |
It will be picked up automatically once we merge it 👍 |
schalkms
left a comment
There was a problem hiding this comment.
Thanks for creating this PR. I think that this change needs a corresponding unit test for regression purposes.
In my opinion detekt should require type resolving to be enabled in order to keep the complexity at a lower rate.
Codecov Report
@@ Coverage Diff @@
## master #2879 +/- ##
=========================================
Coverage 80.17% 80.17%
Complexity 2417 2417
=========================================
Files 421 421
Lines 7358 7358
Branches 1343 1343
=========================================
Hits 5899 5899
Misses 764 764
Partials 695 695
Continue to review full report at Codecov.
|
Check simple string arguments even when type resolution is enabled.
This prevented the
UseRequireandUseCheckOrErrorchecks find issues with TR enabled.