-
-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check string arguments with TR enabled #2879
Conversation
Check simple string arguments even when type resolution is enabled. This prevented the `UseRequire` and `UseCheckOrError` checks find issues with TR enabled.
I'm not sure if / where this has to be described to get picked up by the changelog, or is this done automatically? Or should this just be merged? |
It will be picked up automatically once we merge it 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this PR. I think that this change needs a corresponding unit test for regression purposes.
In my opinion detekt should require type resolving to be enabled in order to keep the complexity at a lower rate.
Codecov Report
@@ Coverage Diff @@
## master #2879 +/- ##
=========================================
Coverage 80.17% 80.17%
Complexity 2417 2417
=========================================
Files 421 421
Lines 7358 7358
Branches 1343 1343
=========================================
Hits 5899 5899
Misses 764 764
Partials 695 695
Continue to review full report at Codecov.
|
Check simple string arguments even when type resolution is enabled.
This prevented the
UseRequire
andUseCheckOrError
checks find issues with TR enabled.