Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check string arguments with TR enabled #2879

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Conversation

realdadfish
Copy link
Contributor

Check simple string arguments even when type resolution is enabled.
This prevented the UseRequire and UseCheckOrError checks find issues with TR enabled.

Check simple string arguments even when type resolution is enabled.
This prevented the `UseRequire` and `UseCheckOrError` checks find issues with TR enabled.
@realdadfish
Copy link
Contributor Author

I'm not sure if / where this has to be described to get picked up by the changelog, or is this done automatically? Or should this just be merged?

@cortinico
Copy link
Member

I'm not sure if / where this has to be described to get picked up by the changelog, or is this done automatically? Or should this just be merged?

It will be picked up automatically once we merge it 👍

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR. I think that this change needs a corresponding unit test for regression purposes.

In my opinion detekt should require type resolving to be enabled in order to keep the complexity at a lower rate.

@realdadfish realdadfish requested a review from schalkms July 18, 2020 21:26
@codecov
Copy link

codecov bot commented Jul 18, 2020

Codecov Report

Merging #2879 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2879   +/-   ##
=========================================
  Coverage     80.17%   80.17%           
  Complexity     2417     2417           
=========================================
  Files           421      421           
  Lines          7358     7358           
  Branches       1343     1343           
=========================================
  Hits           5899     5899           
  Misses          764      764           
  Partials        695      695           
Impacted Files Coverage Δ Complexity Δ
.../gitlab/arturbosch/detekt/rules/KtValueArgument.kt 66.66% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2de31f1...e022d0d. Read the comment docs.

@arturbosch arturbosch merged commit 95ea613 into detekt:master Jul 20, 2020
@arturbosch arturbosch added this to the 1.10.1 milestone Jul 20, 2020
@realdadfish realdadfish deleted the patch-1 branch August 21, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants