Skip to content

Publish to Bintray using maven-publish #2885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2020

Conversation

cortinico
Copy link
Member

@cortinico cortinico commented Jul 20, 2020

Moving Detekt to use only maven-publish for publishing and removing gradle-bintray-plugin.

I think this simplifies overall our setup having a couple of benefits:

There a couple of drawbacks:

  1. Unfortunately due to Gradle 6.0 generates incorrect versions for Kotlin multiplatform projects when publishing to Bintray gradle/gradle#11412 I had to systemProp.org.gradle.internal.publish.checksums.insecure=true. That would have allowed us to publish also locally computed SHA512 for free. This unfortunately confuses Bintray that we're releasing a new version for every module, that is really annoying.

  2. @arturbosch you now need to manually start the Maven Central sync. If needed we can have a Gradle task that hits an HTTP endpoint to start the sync. Otherwise this has to be done manually from the Bintray UI.

Here a sample publishing:
https://bintray.com/cortinico/maven/detekt-sample-publishing/

Fixes #2878

repositories {
maven {
name = "bintray"
url = uri("https://api.bintray.com/maven/arturbosch/code-analysis/detekt/;publish=1;override=1")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could set publish=0 to prevent publishing of a new version from Bintray. Then @arturbosch you would have to manually publish the artifacts from Bintray (this allows to verify the deployment before publishing, maybe it's useful?)

@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #2885 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2885      +/-   ##
============================================
+ Coverage     80.13%   80.18%   +0.04%     
  Complexity     2414     2414              
============================================
  Files           421      421              
  Lines          7355     7357       +2     
  Branches       1342     1342              
============================================
+ Hits           5894     5899       +5     
+ Misses          764      762       -2     
+ Partials        697      696       -1     
Impacted Files Coverage Δ Complexity Δ
...itlab/arturbosch/detekt/api/internal/YamlConfig.kt 84.61% <0.00%> (+3.84%) 9.00% <0.00%> (ø%)
...n/kotlin/io/gitlab/arturbosch/detekt/api/Config.kt 100.00% <0.00%> (+13.33%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9874528...7c4b02c. Read the comment docs.

@arturbosch arturbosch modified the milestones: 1.10.1, 1.11.0 Jul 21, 2020
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Jul 21, 2020
@arturbosch arturbosch merged commit b24851d into detekt:master Jul 21, 2020
@arturbosch arturbosch modified the milestones: 1.11.0, 1.10.1 Aug 2, 2020
@cortinico
Copy link
Member Author

@arturbosch was this working correctly for 1.11.0-RC?

@arturbosch
Copy link
Member

arturbosch commented Aug 3, 2020

Yep, so many files but works greatly! : D Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detekt Deployment is missing Gradle Module files
3 participants