-
-
Notifications
You must be signed in to change notification settings - Fork 794
Publish to Bintray using maven-publish #2885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish to Bintray using maven-publish #2885
Conversation
repositories { | ||
maven { | ||
name = "bintray" | ||
url = uri("https://api.bintray.com/maven/arturbosch/code-analysis/detekt/;publish=1;override=1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could set publish=0
to prevent publishing of a new version from Bintray. Then @arturbosch you would have to manually publish the artifacts from Bintray (this allows to verify the deployment before publishing, maybe it's useful?)
Codecov Report
@@ Coverage Diff @@
## master #2885 +/- ##
============================================
+ Coverage 80.13% 80.18% +0.04%
Complexity 2414 2414
============================================
Files 421 421
Lines 7355 7357 +2
Branches 1342 1342
============================================
+ Hits 5894 5899 +5
+ Misses 764 762 -2
+ Partials 697 696 -1
Continue to review full report at Codecov.
|
@arturbosch was this working correctly for 1.11.0-RC? |
Yep, so many files but works greatly! : D Thanks. |
Moving Detekt to use only
maven-publish
for publishing and removinggradle-bintray-plugin
.I think this simplifies overall our setup having a couple of benefits:
.module
files..md5
files computed locally (partial fix for Sign artifacts and publish checksums #2883)There a couple of drawbacks:
Unfortunately due to Gradle 6.0 generates incorrect versions for Kotlin multiplatform projects when publishing to Bintray gradle/gradle#11412 I had to
systemProp.org.gradle.internal.publish.checksums.insecure=true
. That would have allowed us to publish also locally computed SHA512 for free. This unfortunately confuses Bintray that we're releasing a new version for every module, that is really annoying.@arturbosch you now need to manually start the Maven Central sync. If needed we can have a Gradle task that hits an HTTP endpoint to start the sync. Otherwise this has to be done manually from the Bintray UI.
Here a sample publishing:
https://bintray.com/cortinico/maven/detekt-sample-publishing/
Fixes #2878