OptionalUnit: fix false positive with 'else if'#2888
Merged
Conversation
schalkms
approved these changes
Jul 22, 2020
Codecov Report
@@ Coverage Diff @@
## master #2888 +/- ##
============================================
- Coverage 80.19% 80.18% -0.02%
Complexity 2425 2425
============================================
Files 421 421
Lines 7368 7369 +1
Branches 1349 1349
============================================
Hits 5909 5909
Misses 761 761
- Partials 698 699 +1
Continue to review full report at Codecov.
|
BraisGabin
approved these changes
Jul 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed false positive with 'else if' :
Related: #2886