IgnoredReturnValue: Fix false positive on chained statements#2895
Merged
schalkms merged 1 commit intodetekt:masterfrom Jul 25, 2020
Merged
IgnoredReturnValue: Fix false positive on chained statements#2895schalkms merged 1 commit intodetekt:masterfrom
schalkms merged 1 commit intodetekt:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2895 +/- ##
============================================
- Coverage 80.18% 80.17% -0.02%
- Complexity 2425 2426 +1
============================================
Files 421 421
Lines 7369 7373 +4
Branches 1349 1351 +2
============================================
+ Hits 5909 5911 +2
Misses 761 761
- Partials 699 701 +2
Continue to review full report at Codecov.
|
schalkms
approved these changes
Jul 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the
IgnoredReturnValueto usegetTopmostParentOfTypeinstead ofgetParentOfType. This allows use to capture the whole chain statement and not just the direct parent.Moreover, I'm adding a check to make sure that chains that consumes a value (i.e. returns a
Unit) are excluded from the inspection.Fixes #2890