Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bindingContext function to FileProcessListener - #2872 #2900

Merged
merged 3 commits into from
Jul 28, 2020

Conversation

arturbosch
Copy link
Member

Closes #2872

@arturbosch arturbosch added this to the 1.11.0 milestone Jul 27, 2020
@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #2900 into master will not change coverage.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2900   +/-   ##
=========================================
  Coverage     80.17%   80.17%           
  Complexity     2426     2426           
=========================================
  Files           421      421           
  Lines          7373     7373           
  Branches       1351     1351           
=========================================
  Hits           5911     5911           
  Misses          761      761           
  Partials        701      701           
Impacted Files Coverage Δ Complexity Δ
...otlin/io/gitlab/arturbosch/detekt/core/Analyzer.kt 66.03% <50.00%> (ø) 7.00 <0.00> (ø)
...itlab/arturbosch/detekt/api/FileProcessListener.kt 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...gitlab/arturbosch/detekt/core/tooling/Lifecycle.kt 100.00% <100.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 358c8b0...9a18c1e. Read the comment docs.

Copy link
Member

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

"Use alternative with a binding context.",
ReplaceWith("onStart(files, bindingContext)")
)
fun onStart(files: List<KtFile>) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is there a specific reason why there is a new line between the parentheses here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IntelliJ auto formatting ... idk if they updated it or we never formatted it accordingly

@schalkms
Copy link
Member

We should discuss when we want to have settings for type and symbol solving as a mandatory step. This would reduce the complexity of detekt.

@arturbosch
Copy link
Member Author

arturbosch commented Jul 28, 2020

We should discuss when we want to have settings for type and symbol solving as a mandatory step. This would reduce the complexity of detekt.

This could be quite hard for users with generated code (android) to configure properly. I will soon invest more time in the compiler plugin where we get resolution for free.

@arturbosch arturbosch merged commit c457917 into master Jul 28, 2020
@arturbosch arturbosch deleted the fileprocesslistener-with-context branch July 28, 2020 06:05
@arturbosch arturbosch modified the milestones: 1.11.0, 1.10.1 Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for BindingContext in FileProcessListener
4 participants