-
-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bindingContext function to FileProcessListener - #2872 #2900
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2900 +/- ##
=========================================
Coverage 80.17% 80.17%
Complexity 2426 2426
=========================================
Files 421 421
Lines 7373 7373
Branches 1351 1351
=========================================
Hits 5911 5911
Misses 761 761
Partials 701 701
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
"Use alternative with a binding context.", | ||
ReplaceWith("onStart(files, bindingContext)") | ||
) | ||
fun onStart(files: List<KtFile>) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: is there a specific reason why there is a new line between the parentheses here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IntelliJ auto formatting ... idk if they updated it or we never formatted it accordingly
detekt-api/src/main/kotlin/io/gitlab/arturbosch/detekt/api/FileProcessListener.kt
Outdated
Show resolved
Hide resolved
We should discuss when we want to have settings for type and symbol solving as a mandatory step. This would reduce the complexity of detekt. |
This could be quite hard for users with generated code (android) to configure properly. I will soon invest more time in the compiler plugin where we get resolution for free. |
Closes #2872