Add non-affirming test cases for UselessCallOnNotNull #2918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2918 +/- ##
=========================================
Coverage 80.23% 80.23%
- Complexity 2449 2451 +2
=========================================
Files 421 421
Lines 7406 7406
Branches 1355 1355
=========================================
Hits 5942 5942
Misses 764 764
Partials 700 700 Continue to review full report at Codecov.
|
schalkms
approved these changes
Aug 1, 2020
veyndan
deleted the
housekeeping/UselessCallOnNotNull-negative-test-cases
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old spec only tested the presence of a report when there is something to report. This PR adds tests to ensure that there are no reports when there is nothing to report (i.e., the methods are being used in the correct context).