-
-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to new dokka #2931
Upgrade to new dokka #2931
Conversation
The regression in the Compiler and ktlint not working on kotlin 1.4 are known issues right? I mean, both projects have an issue to track it. |
Yes, KtLint tests against dev versions as of recently. The compiler bug is actually not a bug but a fix, the receiver is actually not needed anymore. |
Being unable to upgrade the Kotlin version and having to turn off analysis because of a dependency, rises the question if we should move the formatting module outside the main repo again ... |
a72884b
to
1969522
Compare
We need to update to 5.3 too. |
Codecov Report
@@ Coverage Diff @@
## master #2931 +/- ##
=========================================
Coverage 79.31% 79.31%
Complexity 2562 2562
=========================================
Files 432 432
Lines 7725 7725
Branches 1466 1466
=========================================
Hits 6127 6127
Misses 814 814
Partials 784 784 Continue to review full report at Codecov.
|
NB -- disables ktlint until 1.4 support. See detekt/detekt#2931
dokka changes its sorting for detekt/detekt-api/src/main/kotlin/io/gitlab/arturbosch/detekt/api/Context.kt Lines 13 to 45 in c6ff711
so our verifyDocumentation will always fail. I've opened Kotlin/dokka#1333 which is a major blocker for using the new dokka and therefore updating Gradle ... |
@@ -29,9 +29,9 @@ object MultiVersionTest : Spek({ | |||
|
|||
private fun getGradleVersionsUnderTest() = | |||
if (getJdkVersion() < 13) { | |||
listOf("5.0", "6.4.1") | |||
listOf("5.3", "6.6") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update our documentation too, right pointing the minimum version.
I've extracted the Kotlin and Gradle upgrade to #2981. |
1350ef0
to
4ca3931
Compare
New version fixed our problem. Huge diff but works as expected. |
This checks if we finally can upgrade Gradle with the new dokka engine.
KtLint is not compatible with Kotlin 1.4-rc so I had to turn off
detekt
andformatting:test
tasks