Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag listOfNotNull if all arguments are non-nullable #2932

Merged
merged 2 commits into from
Aug 6, 2020
Merged

Flag listOfNotNull if all arguments are non-nullable #2932

merged 2 commits into from
Aug 6, 2020

Conversation

veyndan
Copy link
Contributor

@veyndan veyndan commented Aug 5, 2020

Closes #2916.

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #2932 into master will increase coverage by 0.04%.
The diff coverage is 62.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2932      +/-   ##
============================================
+ Coverage     80.23%   80.28%   +0.04%     
- Complexity     2449     2454       +5     
============================================
  Files           421      421              
  Lines          7407     7405       -2     
  Branches       1354     1356       +2     
============================================
+ Hits           5943     5945       +2     
+ Misses          764      757       -7     
- Partials        700      703       +3     
Impacted Files Coverage Δ Complexity Δ
...urbosch/detekt/rules/style/UselessCallOnNotNull.kt 76.47% <62.50%> (-4.30%) 13.00 <5.00> (+5.00) ⬇️
...gitlab/arturbosch/detekt/generator/out/Markdown.kt 18.18% <0.00%> (-2.51%) 4.00% <0.00%> (ø%)
...ls/src/main/kotlin/io/github/detekt/psi/KtFiles.kt 50.00% <0.00%> (+5.55%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d0d8c9...b8a911f. Read the comment docs.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for further improving the rule! Good job 👍
I have one question attached to the review.

@schalkms schalkms merged commit c6fa870 into detekt:master Aug 6, 2020
@veyndan veyndan deleted the 2916 branch August 6, 2020 08:56
@arturbosch arturbosch added this to the 1.11.0 milestone Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flag listOfNotNull if all arguments are non-nullable
3 participants