Add new rule: LibraryEntitiesCannotBePublic

[VovaStelmashchuk]

Close issue #2943

[arturbosch]

Thanks for the contribution.
What is your opinion on extending this rule for top level functions?

[VovaStelmashchuk]

Thanks for the contribution.
What is your opinion on extending this rule for top level functions?

We don't use top level function in our case. But I think it great idea for detekt. Do you want to see this in the current PR?

[arturbosch]

Thanks for the contribution.
What is your opinion on extending this rule for top level functions?

We don't use top level function in our case. But I think it great idea for detekt. Do you want to see this in the current PR?

Sure, should be just a small change :), thanks!

[codecov]

Codecov Report

Merging #2959 into master will increase coverage by 0.01%.
The diff coverage is 85.00%.

@@             Coverage Diff              @@
##             master    #2959      +/-   ##
============================================
+ Coverage     80.24%   80.25%   +0.01%     
- Complexity     2455     2465      +10     
============================================
  Files           422      423       +1     
  Lines          7420     7440      +20     
  Branches       1357     1358       +1     
============================================
+ Hits           5954     5971      +17     
- Misses          762      763       +1     
- Partials        704      706       +2     

Impacted Files	Coverage Δ	Complexity Δ
...kt/rules/style/LibraryEntitiesShouldNotBePublic.kt	84.21% <84.21%> (ø)	10.00 <10.00> (?)
...rturbosch/detekt/rules/style/StyleGuideProvider.kt	100.00% <100.00%> (ø)	2.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc769b5...9f32576. Read the comment docs.

[VovaStelmashchuk]

@arturbosch I added check for top level function. All checks are green now. I recommend to use squash for merge the PR.

[arturbosch]

@arturbosch I added check for top level function. All checks are green now. I recommend to use squash for merge the PR.

Thanks! We squash every PR :).