Add UseRequireNotNull/UseCheckNotNull rules #3003
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3003 +/- ##
============================================
- Coverage 79.76% 79.75% -0.02%
- Complexity 2493 2503 +10
============================================
Files 423 427 +4
Lines 7488 7518 +30
Branches 1409 1418 +9
============================================
+ Hits 5973 5996 +23
Misses 767 767
- Partials 748 755 +7
Continue to review full report at Codecov.
|
| */ | ||
| class UseCheckNotNull(config: Config = Config.empty) : Rule(config) { | ||
| companion object { | ||
| private val requireFunctionFqName = FqName("kotlin.check") |
There was a problem hiding this comment.
| private val requireFunctionFqName = FqName("kotlin.check") | |
| private val checkFunctionFqName = FqName("kotlin.check") |
|
|
||
| override fun visitCallExpression(expression: KtCallExpression) { | ||
| super.visitCallExpression(expression) | ||
| if (expression.isCallingWithNonNullCheckArgument(requireFunctionFqName, bindingContext)) { |
There was a problem hiding this comment.
| if (expression.isCallingWithNonNullCheckArgument(requireFunctionFqName, bindingContext)) { | |
| if (expression.isCallingWithNonNullCheckArgument(checkFunctionFqName, bindingContext)) { |
| ) | ||
|
|
||
| override fun visitCallExpression(expression: KtCallExpression) { | ||
| super.visitCallExpression(expression) |
There was a problem hiding this comment.
Please add a
if (bindingContext == BindingContext.EMPTY) return
just after this statement
| ) | ||
|
|
||
| override fun visitCallExpression(expression: KtCallExpression) { | ||
| super.visitCallExpression(expression) |
There was a problem hiding this comment.
Please add a
if (bindingContext == BindingContext.EMPTY) return
just after this statement
| it("reports a `require` call with a non-null check") { | ||
| val code = """ | ||
| fun test(i: Int?) { | ||
| require(i != null) |
There was a problem hiding this comment.
Can you write a test also for require(null != i)?
| it("reports a `check` call with a non-null check") { | ||
| val code = """ | ||
| fun test(i: Int?) { | ||
| check(i != null) |
There was a problem hiding this comment.
Can you write a test also for check(null != i)?
|
Thanks for the great addition @t-kameyama 🙏 |
| val code = """ | ||
| fun test(i: Int?, j: Int?) { | ||
| require(i != null) | ||
| require(null != j) |
There was a problem hiding this comment.
nit: please split this in two tests. It gives us more granularity in understanding what breaks once a test fails
|
Cool! One rule less on my todo list xD, thanks |
Fixes #2998