Repository navigation
ArrayPrimitive rule: report variable/receiver types and factory methods - #3009
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3009 +/- ##
============================================
- Coverage 79.70% 79.67% -0.04%
- Complexity 2504 2509 +5
============================================
Files 427 427
Lines 7543 7541 -2
Branches 1424 1430 +6
============================================
- Hits 6012 6008 -4
Misses 773 773
- Partials 758 760 +2
Continue to review full report at Codecov.
|
cortinico
reviewed
Aug 24, 2020
| describe("variable type") { | ||
| it("is Array<Primitive>") { | ||
| val code = "val foo: Array<Int>? = null" | ||
| assertThat(subject.compileAndLint(code)).hasSize(1) |
Member
There was a problem hiding this comment.
Suggested change
| assertThat(subject.compileAndLint(code)).hasSize(1) | |
| assertThat(subject.compileAndLintWithContext(env, code)).hasSize(1) |
| describe("receiver type") { | ||
| it("is Array<Primitive>") { | ||
| val code = "fun Array<Long>.foo() { println(this) }" | ||
| assertThat(subject.compileAndLint(code)).hasSize(1) |
Member
There was a problem hiding this comment.
Suggested change
| assertThat(subject.compileAndLint(code)).hasSize(1) | |
| assertThat(subject.compileAndLintWithContext(env, code)).hasSize(1) |
|
|
||
| it("is intArrayOf()") { | ||
| val code = "fun test(x: Int) = intArrayOf(x)" | ||
| assertThat(subject.compileAndLint(code)).isEmpty() |
Member
There was a problem hiding this comment.
Suggested change
| assertThat(subject.compileAndLint(code)).isEmpty() | |
| assertThat(subject.compileAndLintWithContext(env, code)).isEmpty() |
| class ArrayPrimitive(config: Config = Config.empty) : Rule(config) { | ||
| companion object { | ||
| private val primitiveTypes = PrimitiveType.NUMBER_TYPES.map { it.typeName.asString() } | ||
| private val arrayOfFunctionFqName = FqName("kotlin.arrayOf") |
Member
There was a problem hiding this comment.
Follow-up for the future: the same behavior should probably be flagged also for emptyArray()
| @@ -35,44 +41,45 @@ import org.jetbrains.kotlin.psi.psiUtil.collectDescendantsOfType | |||
| * @active since v1.2.0 | |||
Member
There was a problem hiding this comment.
Suggested change
| * @active since v1.2.0 | |
| * @active since v1.2.0 | |
| * @requiresTypeResolution | |
| */ |
arturbosch
approved these changes
Aug 24, 2020
Member
|
Side note: this is a rule that transition from NOT requiring to requiring type resolution. This should probably be noted in the README @arturbosch ? |
schalkms
approved these changes
Aug 24, 2020
BraisGabin
reviewed
Aug 25, 2020
| * fun returningFunction(): DoubleArray { } | ||
| * </compliant> | ||
| * | ||
| * @active since v1.2.0 |
Member
There was a problem hiding this comment.
We should not disable this rule.
Member
There was a problem hiding this comment.
Yup, I picked the wrong line for the suggestion. Updated
arturbosch
approved these changes
Aug 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1245