Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print filtered paths in debug mode for easier bug tracing #3022

Merged
merged 1 commit into from
Aug 29, 2020

Conversation

arturbosch
Copy link
Member

Closes #869

@arturbosch arturbosch added this to the 1.13.0 milestone Aug 26, 2020
@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #3022 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3022   +/-   ##
=========================================
  Coverage     79.15%   79.16%           
- Complexity     2543     2545    +2     
=========================================
  Files           434      434           
  Lines          7714     7717    +3     
  Branches       1465     1467    +2     
=========================================
+ Hits           6106     6109    +3     
  Misses          822      822           
  Partials        786      786           
Impacted Files Coverage Δ Complexity Δ
...io/gitlab/arturbosch/detekt/core/KtTreeCompiler.kt 63.33% <100.00%> (+4.07%) 14.00 <4.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5796850...b6dba9a. Read the comment docs.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be at least unit tests covering the new paths.

@arturbosch arturbosch merged commit 33bdaf4 into master Aug 29, 2020
@arturbosch arturbosch deleted the filtered-files-tracing branch August 29, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print filtered paths in debug mode
3 participants