UnusedImports rule: fix false positives when type resolution is enabled

[t-kameyama]

Closes #3074

[codecov]

Codecov Report

Merging #3079 into master will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##             master    #3079   +/-   ##
=========================================
  Coverage     79.26%   79.26%           
- Complexity     2563     2567    +4     
=========================================
  Files           432      434    +2     
  Lines          7726     7737   +11     
  Branches       1469     1470    +1     
=========================================
+ Hits           6124     6133    +9     
- Misses          816      817    +1     
- Partials        786      787    +1     

Impacted Files	Coverage Δ	Complexity Δ
...lab/arturbosch/detekt/rules/style/UnusedImports.kt	84.12% <66.66%> (-2.76%)	4.00 <0.00> (ø)
...rturbosch/detekt/core/settings/EnvironmentAware.kt	63.15% <0.00%> (ø)	0.00% <0.00%> (ø%)
...ch/detekt/formatting/wrappers/AnnotationSpacing.kt	100.00% <0.00%> (ø)	2.00% <0.00%> (?%)
...detekt/formatting/wrappers/ArgumentListWrapping.kt	100.00% <0.00%> (ø)	2.00% <0.00%> (?%)
...ab/arturbosch/detekt/formatting/KtLintMultiRule.kt	92.30% <0.00%> (+0.24%)	8.00% <0.00%> (ø%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c6a7ea...2f35b03. Read the comment docs.

[3flex]

Thanks @t-kameyama, that's a big improvement! Unfortunately I still have some false positives with type resolution enabled.

Here com.squareup.sqldelight.android.AndroidSqliteDriver is shown as unused, but it's not.

import androidx.sqlite.db.SupportSQLiteDatabase
import androidx.sqlite.db.SupportSQLiteOpenHelper
import com.squareup.sqldelight.android.AndroidSqliteDriver

internal class DbOpenHelper : SupportSQLiteOpenHelper.Callback(DATABASE_VERSION) {

    override fun onCreate(db: SupportSQLiteDatabase) {
        val driver = AndroidSqliteDriver(db)
        Database.Schema.create(driver)
    }
}

I also have annotations in another file which are used, but they're still being reported.

[t-kameyama]

@3flex
Fixed in 8ace339

[3flex]

Awesome :) A couple more, where the reference resolves to a companion object...

Lots of code omitted here, but the import is reported when it's used like this:

import com.bluelinelabs.conductor.RouterTransaction

RouterTransaction.with(DomainListController())

That resolves to:

class RouterTransaction {
  companion object {

    @JvmStatic
    fun with(controller: Controller): RouterTransaction = RouterTransaction(controller)
  }
}

And another example, again, lots of code omitted:

import okhttp3.ConnectionSpec

ConnectionSpec.MODERN_TLS
ConnectionSpec.COMPATIBLE_TLS

Both of those variables sit in a companion object.

[t-kameyama]

@3flex
Fixed in 096c441

[3flex]

Amazing! I can enable the rule with TR enabled now.

Possibly there will be other cases that pop up but this resolves my initial issue.

[cortinico]

Thanks for the fix @t-kameyama
Would you be able to cherry pick #3077 so to make sure we're not introducing further regressions in the test suite for UnusedImports

[t-kameyama]

@cortinico
Fixed in 2f35b03

[arturbosch]

@cortinico we can close #3077 now, right?

[cortinico]

@cortinico we can close #3077 now, right?

Yup 👌