Improve description of AbsentOrWrongFileLicense rule #3109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new description states how the rule checks Kotlin source files against the given license header. Closes #3100
Codecov Report
@@ Coverage Diff @@
## master #3109 +/- ##
=========================================
Coverage 79.44% 79.44%
Complexity 2596 2596
=========================================
Files 437 437
Lines 7818 7818
Branches 1484 1484
=========================================
Hits 6211 6211
Misses 819 819
Partials 788 788
Continue to review full report at Codecov.
|
arturbosch
reviewed
Sep 27, 2020
| @@ -10,7 +10,9 @@ import io.gitlab.arturbosch.detekt.api.Severity | |||
| import org.jetbrains.kotlin.psi.KtFile | |||
|
|
|||
| /** | |||
| * This rule will report every Kotlin source file which doesn't have required license header. | |||
| * This rule will report every Kotlin source file which doesn't have the required license header. | |||
| * Each Kotlin source file is checked, whether the header starts with the read text from the passed file in the | |||
There was a problem hiding this comment.
Suggested change
| * Each Kotlin source file is checked, whether the header starts with the read text from the passed file in the | |
| * Each Kotlin source file is checked whether the header starts with the read text from the passed file in the |
Not sure if the comma is needs to be removed here.
arturbosch
approved these changes
Sep 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new description states how the rule checks Kotlin source files
against the given license header.
Closes #3100