Skip to content

Write recipe to compare user and default config - #3065#3114

Merged
arturbosch merged 1 commit intomasterfrom
diff-recipe
Sep 30, 2020
Merged

Write recipe to compare user and default config - #3065#3114
arturbosch merged 1 commit intomasterfrom
diff-recipe

Conversation

@arturbosch
Copy link
Member

No description provided.

@arturbosch arturbosch added this to the 1.14.1 milestone Sep 27, 2020
@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #3114 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3114   +/-   ##
=========================================
  Coverage     79.44%   79.44%           
  Complexity     2596     2596           
=========================================
  Files           437      437           
  Lines          7818     7818           
  Branches       1484     1484           
=========================================
  Hits           6211     6211           
  Misses          819      819           
  Partials        788      788           
Impacted Files Coverage Δ Complexity Δ
...kt/rules/documentation/AbsentOrWrongFileLicense.kt 92.85% <0.00%> (ø) 8.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21af91e...e915dab. Read the comment docs.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing ✍️ this article. It’s a very helpful reference for potential questions concerning this topic.

@Tolriq
Copy link

Tolriq commented Sep 28, 2020

Actually what I do is not diff updated config with prod config but diff default config with previous default config.

This give a precise and easy to follow list of added checks / changed default values that can be applied to prod after.

Diffing default config with prod configuration that may have dozens of already known changes makes this task harder.

@arturbosch arturbosch merged commit 5fa448d into master Sep 30, 2020
@arturbosch arturbosch deleted the diff-recipe branch September 30, 2020 20:54
@BraisGabin
Copy link
Member

Actually what I do is not diff updated config with prod config but diff default config with previous default config.

This give a precise and easy to follow list of added checks / changed default values that can be applied to prod after.

Diffing default config with prod configuration that may have dozens of already known changes makes this task harder.

My workflow is similar at yours. And I have an idea but I must say that I don't use it yet:

Create a patch file between the default config and my actual config. This way, the next time that I update detekt I can take the new default and apply the patch to it. And then I can diff my old config with the merge between my customization and the new default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants