Skip to content

UnusedPrivateMember: fix false positive with getValue/setValue operator functions #3139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2020
Merged

UnusedPrivateMember: fix false positive with getValue/setValue operator functions #3139

merged 2 commits into from
Oct 12, 2020

Conversation

t-kameyama
Copy link
Contributor

Fixes #3128

@codecov
Copy link

codecov bot commented Oct 9, 2020 •
edited
Loading

Codecov Report

Merging #3139 into master will increase coverage by 0.02%.
The diff coverage is 78.94%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3139      +/-   ##
============================================
+ Coverage     79.43%   79.46%   +0.02%     
  Complexity     2597     2597              
============================================
  Files           437      437              
  Lines          7820     7835      +15     
  Branches       1484     1489       +5     
============================================
+ Hits           6212     6226      +14     
+ Misses          819      818       -1     
- Partials        789      791       +2
Impacted Files Coverage Δ Complexity Δ
...turbosch/detekt/rules/style/UnusedPrivateMember.kt 90.62% <78.94%> (+0.35%) 5.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ce376e...525ecbf. Read the comment docs.

BraisGabin
BraisGabin reviewed Oct 10, 2020
View reviewed changes
...t-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMember.kt Outdated

override fun getUnusedReports(issue: Issue): List<CodeSmell> {
val propertyDelegateResultingDescriptors by lazy {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use lazy, use the none policy. You don't need concurrent safity here.

@t-kameyama t-kameyama requested a review from BraisGabin October 10, 2020 09:52
@schalkms schalkms merged commit a387090 into detekt:master Oct 12, 2020
@t-kameyama t-kameyama deleted the issue_3128 branch October 12, 2020 21:22
@arturbosch arturbosch added this to the 1.14.2 milestone Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

@schalkms schalkms schalkms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14.2
Development

Successfully merging this pull request may close these issues.

False positive UnusedPrivateMember for getValue, setValue operator functions
4 participants
@t-kameyama @BraisGabin @schalkms @arturbosch