Skip to content

Change spek and assertj to compile only dependencies for detekt-test consumers #3152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2020

Conversation

arturbosch
Copy link
Member

@arturbosch arturbosch commented Oct 18, 2020

Closes #3082

Tested with the intellij plugin.
No need to exclude these dependencies anymore:

   testImplementation("io.gitlab.arturbosch.detekt:detekt-test-utils:$detektVersion") {
       exclude(group = "org.assertj")
       exclude(group = "org.spekframework.spek2")
   }

@arturbosch arturbosch added this to the 1.14.2 milestone Oct 18, 2020
@codecov
Copy link

codecov bot commented Oct 18, 2020

Codecov Report

Merging #3152 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3152   +/-   ##
=========================================
  Coverage     79.52%   79.52%           
  Complexity     2592     2592           
=========================================
  Files           437      437           
  Lines          7852     7852           
  Branches       1495     1495           
=========================================
  Hits           6244     6244           
  Misses          817      817           
  Partials        791      791           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3108bfc...afe6338. Read the comment docs.

@schalkms schalkms merged commit 1d7bd33 into master Oct 18, 2020
@schalkms schalkms deleted the compileOnly-spek-assertj branch October 18, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artifact detekt-test foreces dependency constraining
2 participants