Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move internal config api to core module #3163

Merged
merged 4 commits into from
Nov 2, 2020

Conversation

arturbosch
Copy link
Member

@arturbosch arturbosch commented Oct 21, 2020

The Config implementation was deprecated in march 2020, typealiases removed in 1.13 and now we can move that stuff into core :)

  • moves internal config api to core module
  • removes remaining usages of YamlConfig in code; tests should use yamlConfig
  • removes implementation dependency snakeyaml from api module
  • removes BaseConfig; it's members are now plain functions

@arturbosch arturbosch added this to the 1.15.0 milestone Oct 21, 2020
@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #3163 into master will decrease coverage by 0.00%.
The diff coverage is 96.15%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3163      +/-   ##
============================================
- Coverage     79.51%   79.51%   -0.01%     
+ Complexity     2599     2587      -12     
============================================
  Files           437      437              
  Lines          7865     7864       -1     
  Branches       1497     1498       +1     
============================================
- Hits           6254     6253       -1     
  Misses          817      817              
  Partials        794      794              
Impacted Files Coverage Δ Complexity Δ
...otlin/io/gitlab/arturbosch/detekt/core/Analyzer.kt 67.64% <ø> (ø) 6.00 <0.00> (ø)
...b/arturbosch/detekt/core/config/CompositeConfig.kt 66.66% <ø> (ø) 5.00 <0.00> (?)
...ab/arturbosch/detekt/core/config/Configurations.kt 83.33% <ø> (ø) 0.00 <0.00> (ø)
...lab/arturbosch/detekt/core/config/DefaultConfig.kt 100.00% <ø> (ø) 2.00 <0.00> (ø)
...kt/core/config/DefaultPropertiesConfigValidator.kt 100.00% <ø> (ø) 1.00 <0.00> (ø)
...ch/detekt/core/config/DisabledAutoCorrectConfig.kt 44.44% <ø> (ø) 5.00 <0.00> (?)
...ab/arturbosch/detekt/core/config/FailFastConfig.kt 36.36% <ø> (ø) 5.00 <0.00> (?)
...sch/detekt/core/config/ValidatableConfiguration.kt 96.87% <ø> (ø) 0.00 <0.00> (?)
...gitlab/arturbosch/detekt/core/config/YamlConfig.kt 76.00% <ø> (ø) 9.00 <0.00> (?)
...gitlab/arturbosch/detekt/core/config/BaseConfig.kt 96.15% <96.15%> (ø) 0.00 <0.00> (?)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fefbf3f...1c8d7dd. Read the comment docs.

@arturbosch arturbosch merged commit 5c2d96f into master Nov 2, 2020
@arturbosch arturbosch deleted the move-internal-config-to-core branch November 2, 2020 09:15
sowmyav24 pushed a commit to sowmyav24/detekt that referenced this pull request Nov 8, 2020
* Move internal config api to core module

* Move YamlConfig to core and remove all remaining references

* Remove yaml dependency from api module

* Revert visibility modifier change
arturbosch added a commit that referenced this pull request Nov 15, 2020
* Move internal config api to core module

* Move YamlConfig to core and remove all remaining references

* Remove yaml dependency from api module

* Revert visibility modifier change
@arturbosch arturbosch added the migration Marker to add a migration step in the changelog label Nov 26, 2020
arturbosch added a commit that referenced this pull request Dec 21, 2020
* Move internal config api to core module

* Move YamlConfig to core and remove all remaining references

* Remove yaml dependency from api module

* Revert visibility modifier change
arturbosch added a commit that referenced this pull request Jan 16, 2021
* Move internal config api to core module

* Move YamlConfig to core and remove all remaining references

* Remove yaml dependency from api module

* Revert visibility modifier change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration Marker to add a migration step in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants