-
-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move internal config api to core module #3163
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3163 +/- ##
============================================
- Coverage 79.51% 79.51% -0.01%
+ Complexity 2599 2587 -12
============================================
Files 437 437
Lines 7865 7864 -1
Branches 1497 1498 +1
============================================
- Hits 6254 6253 -1
Misses 817 817
Partials 794 794
Continue to review full report at Codecov.
|
cortinico
approved these changes
Oct 23, 2020
schalkms
approved these changes
Oct 23, 2020
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Nov 8, 2020
* Move internal config api to core module * Move YamlConfig to core and remove all remaining references * Remove yaml dependency from api module * Revert visibility modifier change
arturbosch
added a commit
that referenced
this pull request
Nov 15, 2020
* Move internal config api to core module * Move YamlConfig to core and remove all remaining references * Remove yaml dependency from api module * Revert visibility modifier change
arturbosch
added a commit
that referenced
this pull request
Dec 21, 2020
* Move internal config api to core module * Move YamlConfig to core and remove all remaining references * Remove yaml dependency from api module * Revert visibility modifier change
arturbosch
added a commit
that referenced
this pull request
Jan 16, 2021
* Move internal config api to core module * Move YamlConfig to core and remove all remaining references * Remove yaml dependency from api module * Revert visibility modifier change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Config implementation was deprecated in march 2020, typealiases removed in 1.13 and now we can move that stuff into core :)
YamlConfig
in code; tests should useyamlConfig
snakeyaml
from api moduleBaseConfig
; it's members are now plain functions