Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MaxLineLengthSuppressed ignoring @Suppress annotation on class #3164

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

cortinico
Copy link
Member

Fixes #3136

The MaxLineLength rule was failing to pickup the parent KtElement when reporting a line from a long comment. This caused the @Suppress annotation on the class to be ignored.

@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #3164 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3164      +/-   ##
============================================
- Coverage     79.51%   79.47%   -0.04%     
+ Complexity     2599     2596       -3     
============================================
  Files           437      437              
  Lines          7865     7860       -5     
  Branches       1497     1498       +1     
============================================
- Hits           6254     6247       -7     
- Misses          817      818       +1     
- Partials        794      795       +1     
Impacted Files Coverage Δ Complexity Δ
...in/io/gitlab/arturbosch/detekt/rules/style/Junk.kt 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...lab/arturbosch/detekt/rules/style/MaxLineLength.kt 79.41% <0.00%> (-5.89%) 22.00% <0.00%> (-1.00%)
...n/io/github/detekt/report/html/HtmlOutputReport.kt 94.28% <0.00%> (-0.46%) 18.00% <0.00%> (-2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cee6149...090a669. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@Suppress("MaxLineLength") not working for simple block comment inside class
3 participants