Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive in IgnoredReturnValue #3169

Merged
merged 4 commits into from
Oct 26, 2020
Merged

Conversation

BraisGabin
Copy link
Member

Fixes #3043

@BraisGabin BraisGabin changed the title Fix IgnoredReturnValue Fix false positive in IgnoredReturnValue Oct 25, 2020
@codecov
Copy link

codecov bot commented Oct 25, 2020

Codecov Report

Merging #3169 into master will increase coverage by 0.05%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3169      +/-   ##
============================================
+ Coverage     79.45%   79.51%   +0.05%     
- Complexity     2592     2602      +10     
============================================
  Files           437      438       +1     
  Lines          7871     7913      +42     
  Branches       1501     1510       +9     
============================================
+ Hits           6254     6292      +38     
- Misses          820      821       +1     
- Partials        797      800       +3     
Impacted Files Coverage Δ Complexity Δ
...arturbosch/detekt/rules/bugs/IgnoredReturnValue.kt 77.08% <75.00%> (+1.57%) 18.00 <1.00> (+4.00)
...bosch/detekt/formatting/KtLintLineColCalculator.kt 88.09% <88.09%> (ø) 6.00 <6.00> (?)
...lab/arturbosch/detekt/formatting/FormattingRule.kt 96.42% <100.00%> (+0.13%) 11.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2705f09...7191d5c. Read the comment docs.

@BraisGabin BraisGabin force-pushed the issue-3043 branch 3 times, most recently from fdc57f9 to 9d68c69 Compare October 25, 2020 15:28
@schalkms schalkms merged commit 3bfdae8 into detekt:master Oct 26, 2020
@BraisGabin BraisGabin deleted the issue-3043 branch October 26, 2020 09:59
@arturbosch arturbosch added this to the 1.15.0 milestone Nov 2, 2020
arturbosch pushed a commit that referenced this pull request Nov 15, 2020
* Improve tests

* Fix IgnoredReturnValue

* Simplify code

* Simplify even more
arturbosch pushed a commit that referenced this pull request Dec 21, 2020
* Improve tests

* Fix IgnoredReturnValue

* Simplify code

* Simplify even more
arturbosch pushed a commit that referenced this pull request Jan 16, 2021
* Improve tests

* Fix IgnoredReturnValue

* Simplify code

* Simplify even more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IgnoredReturnValue false positives
3 participants