Skip to content

Hardcode default values #3171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Hardcode default values #3171

merged 1 commit into from
Oct 26, 2020

Conversation

BraisGabin
Copy link
Member

Closes #2597

We had some rule configurations with wrong default values.

@codecov
Copy link

codecov bot commented Oct 25, 2020

Codecov Report

Merging #3171 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3171      +/-   ##
============================================
+ Coverage     79.45%   79.52%   +0.07%     
- Complexity     2592     2599       +7     
============================================
  Files           437      438       +1     
  Lines          7871     7923      +52     
  Branches       1501     1509       +8     
============================================
+ Hits           6254     6301      +47     
- Misses          820      821       +1     
- Partials        797      801       +4     
Impacted Files Coverage Δ Complexity Δ
...eptions/ThrowingExceptionsWithoutMessageOrCause.kt 89.47% <100.00%> (+9.47%) 7.00 <1.00> (+1.00)
...h/detekt/rules/style/DataClassContainsFunctions.kt 94.11% <100.00%> (ø) 8.00 <0.00> (ø)
...etekt/rules/style/FunctionOnlyReturningConstant.kt 96.87% <100.00%> (ø) 28.00 <0.00> (ø)
...itlab/arturbosch/detekt/rules/style/ReturnCount.kt 95.12% <100.00%> (ø) 11.00 <0.00> (ø)
...bosch/detekt/formatting/KtLintLineColCalculator.kt 88.09% <0.00%> (ø) 6.00% <0.00%> (?%)
...lab/arturbosch/detekt/formatting/FormattingRule.kt 96.42% <0.00%> (+0.13%) 11.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2705f09...fbaeb37. Read the comment docs.

@schalkms schalkms merged commit 423ade4 into detekt:master Oct 26, 2020
@arturbosch arturbosch added this to the 1.15.0 milestone Nov 2, 2020
arturbosch pushed a commit that referenced this pull request Nov 15, 2020
arturbosch pushed a commit that referenced this pull request Dec 21, 2020
arturbosch pushed a commit that referenced this pull request Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove hardcoded default values from rules
3 participants