Skip to content

Move KtFileContent to FileParsingRule #3173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Move KtFileContent to FileParsingRule #3173

merged 1 commit into from
Oct 26, 2020

Conversation

BraisGabin
Copy link
Member

KtFileContent is used for more rules than MaxLineLength so it should not be declared in that file. FileParsingRule.kt is a better place because is where the constructor of that class is called.

@codecov
Copy link

codecov bot commented Oct 25, 2020

Codecov Report

Merging #3173 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3173      +/-   ##
============================================
+ Coverage     79.45%   79.50%   +0.04%     
- Complexity     2592     2598       +6     
============================================
  Files           437      438       +1     
  Lines          7871     7914      +43     
  Branches       1501     1509       +8     
============================================
+ Hits           6254     6292      +38     
- Misses          820      821       +1     
- Partials        797      801       +4     
Impacted Files Coverage Δ Complexity Δ
...lab/arturbosch/detekt/rules/style/MaxLineLength.kt 78.78% <ø> (-0.63%) 22.00 <0.00> (ø)
...b/arturbosch/detekt/rules/style/FileParsingRule.kt 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
...bosch/detekt/formatting/KtLintLineColCalculator.kt 88.09% <0.00%> (ø) 6.00% <0.00%> (?%)
...lab/arturbosch/detekt/formatting/FormattingRule.kt 96.42% <0.00%> (+0.13%) 11.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2705f09...0b2b0ad. Read the comment docs.

@schalkms schalkms merged commit c784f48 into detekt:master Oct 26, 2020
@arturbosch arturbosch added this to the 1.15.0 milestone Nov 2, 2020
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants