Improves in IgnoredReturnValue #3174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3174 +/- ##
============================================
+ Coverage 79.53% 79.55% +0.01%
+ Complexity 2603 2602 -1
============================================
Files 438 438
Lines 7922 7922
Branches 1510 1510
============================================
+ Hits 6301 6302 +1
+ Misses 821 820 -1
Partials 800 800
Continue to review full report at Codecov.
|
schalkms
reviewed
Oct 26, 2020
Fine for me 👍 It makes clearer that we have that scenario to address. |
cortinico
approved these changes
Oct 26, 2020
arturbosch
pushed a commit
that referenced
this pull request
Nov 15, 2020
* Improve tests * Add missing packages * Improve tests * Improve code * Add fixme in the wrong test
arturbosch
pushed a commit
that referenced
this pull request
Dec 21, 2020
* Improve tests * Add missing packages * Improve tests * Improve code * Add fixme in the wrong test
arturbosch
pushed a commit
that referenced
this pull request
Jan 16, 2021
* Improve tests * Add missing packages * Improve tests * Improve code * Add fixme in the wrong test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last night I was working on #3170. I couldn't find the way to fix it but I did some refactors around the code/test that make it the code more maintenable and create the test that should be changed to show the error.
What do you think about merging the comment with
FIXME? We have the error right now, this comment only points out it.