Fix false negative in IgnoredReturnValue#3179
Merged
schalkms merged 5 commits intodetekt:masterfrom Oct 28, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3179 +/- ##
============================================
- Coverage 79.58% 79.57% -0.02%
+ Complexity 2610 2606 -4
============================================
Files 439 439
Lines 7935 7920 -15
Branches 1511 1502 -9
============================================
- Hits 6315 6302 -13
Misses 820 820
+ Partials 800 798 -2
Continue to review full report at Codecov.
|
BraisGabin
reviewed
Oct 27, 2020
|
|
||
| val parentQualifiedExpression = expression.getStrictParentOfType<KtQualifiedExpression>() | ||
| if (parentQualifiedExpression != null && parentQualifiedExpression.selectorExpression != expression) return | ||
| if (expression.isUsedAsExpression(bindingContext)) return |
Member
There was a problem hiding this comment.
🤔 what if the statment is not the last of the if? I mean:
val a = if (random()) {
2
} else {
returnsInt()
3
}Is this handled correctly?
Contributor
Author
There was a problem hiding this comment.
Yes 5c2d3e3, but the following case is not flagged. I will fix.
if (Random.nextBoolean()) {
1
} else {
returnsInt()
2
}.plus(1)… and 'if' block is used" test
t-kameyama
force-pushed
the
issue_3170
branch
from
b77f63b to
8927806
Compare
schalkms
approved these changes
Oct 28, 2020
arturbosch
pushed a commit
that referenced
this pull request
Nov 15, 2020
* Fix false negative in IgnoredReturnValue * Add "report when a function is not the last statement in a 'if' block and 'if' block is used" test * Report when a function is not the last statement in a block and it's in a chain * Refactor * Add @Suppress(LargeClass)
arturbosch
pushed a commit
that referenced
this pull request
Dec 21, 2020
* Fix false negative in IgnoredReturnValue * Add "report when a function is not the last statement in a 'if' block and 'if' block is used" test * Report when a function is not the last statement in a block and it's in a chain * Refactor * Add @Suppress(LargeClass)
arturbosch
pushed a commit
that referenced
this pull request
Jan 16, 2021
* Fix false negative in IgnoredReturnValue * Add "report when a function is not the last statement in a 'if' block and 'if' block is used" test * Report when a function is not the last statement in a block and it's in a chain * Refactor * Add @Suppress(LargeClass)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3170