Add RedundantHigherOrderMapUsage rule #3182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-kameyama
force-pushed
the
issue_2975
branch
from
8194ca6 to
55d4af7
Compare
Codecov Report
@@ Coverage Diff @@
## master #3182 +/- ##
============================================
- Coverage 79.58% 79.53% -0.05%
- Complexity 2603 2631 +28
============================================
Files 439 440 +1
Lines 7919 7966 +47
Branches 1502 1521 +19
============================================
+ Hits 6302 6336 +34
Misses 820 820
- Partials 797 810 +13
Continue to review full report at Codecov.
|
BraisGabin
approved these changes
Oct 28, 2020
| assertThat(findings).hasSize(1) | ||
| assertThat(findings).hasSourceLocation(5, 10) | ||
| assertThat(findings[0]).hasMessage("This 'map' call can be replaced with 'onEach' or 'forEach'.") | ||
| } |
There was a problem hiding this comment.
This! 👏👏👏👏👏 I saw it SO MANY TIMES! A map that should be replaced with an onEach. And it slow down the reading of the code a lot.
| import org.jetbrains.kotlin.types.KotlinType | ||
|
|
||
| /** | ||
| * Turn on this rule to flag redundant 'map' calls. |
There was a problem hiding this comment.
I would change the description with something like:
Redundant maps add complexity to the code and accomplish nothing. They should be removed or replaced with the proper operator.
cortinico
approved these changes
Oct 28, 2020
Comment on lines
100
to
108
| val message = if (lambdaStatements.size == 1) { | ||
| if (receiverIsSet) { | ||
| "This 'map' call can be replaced with 'toList'." | ||
| } else { | ||
| "This 'map' call can be removed." | ||
| } | ||
| } else { | ||
| "This 'map' call can be replaced with 'onEach' or 'forEach'." | ||
| } |
There was a problem hiding this comment.
Can you convert this to a when?
t-kameyama
force-pushed
the
issue_2975
branch
from
7835d1a to
460da97
Compare
t-kameyama
force-pushed
the
issue_2975
branch
from
460da97 to
c8e57dd
Compare
cortinico
approved these changes
Oct 29, 2020
BraisGabin
approved these changes
Oct 29, 2020
schalkms
approved these changes
Oct 29, 2020
arturbosch
pushed a commit
that referenced
this pull request
Nov 15, 2020
* Add RedundantHigherOrderMapUsage rule * Fix description * Convert `if` to `when`
arturbosch
pushed a commit
that referenced
this pull request
Dec 21, 2020
* Add RedundantHigherOrderMapUsage rule * Fix description * Convert `if` to `when`
arturbosch
pushed a commit
that referenced
this pull request
Jan 16, 2021
* Add RedundantHigherOrderMapUsage rule * Fix description * Convert `if` to `when`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2975