Add allowElseExpression configuration for MissingWhenCase rule #3187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3187 +/- ##
=========================================
Coverage 79.55% 79.56%
- Complexity 2631 2632 +1
=========================================
Files 440 440
Lines 7964 7967 +3
Branches 1521 1520 -1
=========================================
+ Hits 6336 6339 +3
Misses 818 818
Partials 810 810
Continue to review full report at Codecov.
|
sowmyav24
force-pushed
the
list-all-when-cases
branch
from
dc267b5 to
5b8e2a2
Compare
sowmyav24
force-pushed
the
list-all-when-cases
branch
from
5b8e2a2 to
e926acd
Compare
BraisGabin
reviewed
Oct 31, 2020
...les-errorprone/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/MissingWhenCaseSpec.kt
Show resolved
Hide resolved
...t-rules-errorprone/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/MissingWhenCase.kt
Outdated
Show resolved
Hide resolved
cortinico
reviewed
Oct 31, 2020
...t-rules-errorprone/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/MissingWhenCase.kt
Outdated
Show resolved
Hide resolved
...t-rules-errorprone/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/MissingWhenCase.kt
Outdated
Show resolved
Hide resolved
...t-rules-errorprone/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/MissingWhenCase.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Nicola Corti <corti.nico@gmail.com>
arturbosch
approved these changes
Oct 31, 2020
schalkms
reviewed
Oct 31, 2020
Member
schalkms
left a comment
schalkms
left a comment
There was a problem hiding this comment.
Thanks for this PR! Please see my attached comments, which only remarks the formatting of a few lines.
...les-errorprone/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/MissingWhenCaseSpec.kt
Outdated
Show resolved
Hide resolved
...les-errorprone/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/MissingWhenCaseSpec.kt
Show resolved
Hide resolved
...les-errorprone/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/MissingWhenCaseSpec.kt
Outdated
Show resolved
Hide resolved
...les-errorprone/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/MissingWhenCaseSpec.kt
Show resolved
Hide resolved
...les-errorprone/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/MissingWhenCaseSpec.kt
Show resolved
Hide resolved
...les-errorprone/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/MissingWhenCaseSpec.kt
Show resolved
Hide resolved
schalkms
approved these changes
Nov 1, 2020
arturbosch
pushed a commit
that referenced
this pull request
Nov 15, 2020
* Add allowElseExpression configuration for MissingWhenCase rule * Add test for non enum, sealed when cases * Update function name to report missing cases Co-authored-by: Nicola Corti <corti.nico@gmail.com> * Update documentation and remove redundant variable * Fix discrepency while commiting from github * Fix formatting issues in test classes Co-authored-by: Nicola Corti <corti.nico@gmail.com>
arturbosch
pushed a commit
that referenced
this pull request
Dec 21, 2020
* Add allowElseExpression configuration for MissingWhenCase rule * Add test for non enum, sealed when cases * Update function name to report missing cases Co-authored-by: Nicola Corti <corti.nico@gmail.com> * Update documentation and remove redundant variable * Fix discrepency while commiting from github * Fix formatting issues in test classes Co-authored-by: Nicola Corti <corti.nico@gmail.com>
arturbosch
pushed a commit
that referenced
this pull request
Jan 16, 2021
* Add allowElseExpression configuration for MissingWhenCase rule * Add test for non enum, sealed when cases * Update function name to report missing cases Co-authored-by: Nicola Corti <corti.nico@gmail.com> * Update documentation and remove redundant variable * Fix discrepency while commiting from github * Fix formatting issues in test classes Co-authored-by: Nicola Corti <corti.nico@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3176
allowElseExpressionand default it to true.