Check for static imports in unused imports rule

[sowmyav24]

Fixes #3131

[codecov]

Codecov Report

Merging #3188 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #3188      +/-   ##
============================================
+ Coverage     79.55%   79.57%   +0.01%     
  Complexity     2631     2631              
============================================
  Files           440      440              
  Lines          7964     7969       +5     
  Branches       1521     1522       +1     
============================================
+ Hits           6336     6341       +5     
  Misses          818      818              
  Partials        810      810              

Impacted Files	Coverage Δ	Complexity Δ
...lab/arturbosch/detekt/rules/style/UnusedImports.kt	85.29% <100.00%> (+1.16%)	4.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da6259a...efabb70. Read the comment docs.

[sowmyav24]

When I run the task ./gradlew :detekt-rules-style:test in local it passes. In CI it seems to fails for test-snippet compilation.

[BraisGabin]

Use ./gradlew :detekt-rules-style:test -Pcompile-test-snippets=true

Compile all the snippets each time that we run the tests slow down the test and is kind of meta testing (testing the tests). For that reason we have the compilation disabled by default and we just compile them in CI.

import org.eclipse.persistence.annotations.FetchType is not in the classpath so it fails. compileAndLintWithContext allows multiple Strings that are like different files. This way you can create your own enum in other package and then use it in your test.

[BraisGabin]

Why does this compile? the enum is called FetchType but the import is for Foo 🤔

[sowmyav24]

I wrote the tests with Foo and later renamed them before committing to mimic the issue reported. However, your point of compilation seems to be valid 😮

[BraisGabin]

@schalkms do you have any idea about why does this happen? This doesn't stop the PR but I will like to know why does this happen

[schalkms]

@BraisGabin Yes, I do. Please take a look at the following lines and closely check line number 68.

detekt/detekt-test/src/main/kotlin/io/gitlab/arturbosch/detekt/test/RuleExtensions.kt

Lines 63 to 72 in da6259a

	fun BaseRule.compileAndLintWithContext(
	environment: KotlinCoreEnvironment,
	@Language("kotlin") content: String,
	@Language("kotlin") vararg additionalContents: String,
	): List<Finding> {
	if (shouldCompileTestSnippets && additionalContents.isEmpty()) {
	KotlinScriptEngine.compile(content)
	}
	return lintWithContext(environment, content, *additionalContents)
	}