Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code coverage for DefaultCliInvoker testing happy and error path #3195

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

arturbosch
Copy link
Member

No description provided.

@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Nov 2, 2020
@arturbosch arturbosch added this to the 1.15.0 milestone Nov 2, 2020
@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #3195 into master will increase coverage by 0.26%.
The diff coverage is 90.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3195      +/-   ##
============================================
+ Coverage     79.57%   79.84%   +0.26%     
+ Complexity     2620     2610      -10     
============================================
  Files           440      439       -1     
  Lines          7971     7953      -18     
  Branches       1522     1516       -6     
============================================
+ Hits           6343     6350       +7     
+ Misses          818      790      -28     
- Partials        810      813       +3     
Impacted Files Coverage Δ Complexity Δ
...lab/arturbosch/detekt/internal/ClassLoaderCache.kt 31.57% <85.71%> (ø) 0.00 <0.00> (-6.00)
...o/gitlab/arturbosch/detekt/invoke/DetektInvoker.kt 50.00% <100.00%> (+40.32%) 0.00 <0.00> (ø)
...ab/arturbosch/detekt/rules/bugs/HasPlatformType.kt 69.56% <0.00%> (ø) 10.00% <0.00%> (ø%)
...ab/arturbosch/detekt/rules/bugs/MissingWhenCase.kt 90.62% <0.00%> (ø) 11.00% <0.00%> (ø%)
...urbosch/detekt/rules/style/UselessCallOnNotNull.kt 76.47% <0.00%> (ø) 14.00% <0.00%> (ø%)
...rbosch/detekt/rules/style/RedundantExplicitType.kt 64.51% <0.00%> (ø) 15.00% <0.00%> (ø%)
...rturbosch/detekt/rules/bugs/RedundantElseInWhen.kt 66.66% <0.00%> (ø) 6.00% <0.00%> (ø%)
...etekt/rules/coroutines/RedundantSuspendModifier.kt 59.09% <0.00%> (ø) 20.00% <0.00%> (ø%)
...ain/kotlin/io/gitlab/arturbosch/detekt/cli/Main.kt

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c2d96f...d4a2fcb. Read the comment docs.

@schalkms schalkms merged commit a738300 into master Nov 2, 2020
@schalkms schalkms deleted the invoker-code-coverage branch November 2, 2020 18:05
sowmyav24 pushed a commit to sowmyav24/detekt that referenced this pull request Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants