Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor UselessCallOnNotNull rule #3208

Merged
merged 2 commits into from
Nov 9, 2020
Merged

Refactor UselessCallOnNotNull rule #3208

merged 2 commits into from
Nov 9, 2020

Conversation

schalkms
Copy link
Member

@schalkms schalkms commented Nov 7, 2020

No description provided.

@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #3208 (b1bdbe2) into master (7f8ee20) will increase coverage by 0.03%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3208      +/-   ##
============================================
+ Coverage     80.07%   80.10%   +0.03%     
- Complexity     2638     2641       +3     
============================================
  Files           440      440              
  Lines          8019     8022       +3     
  Branches       1540     1538       -2     
============================================
+ Hits           6421     6426       +5     
  Misses          775      775              
+ Partials        823      821       -2     
Impacted Files Coverage Δ Complexity Δ
...urbosch/detekt/rules/style/UselessCallOnNotNull.kt 83.78% <81.81%> (+7.31%) 17.00 <4.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f8ee20...b1bdbe2. Read the comment docs.

@schalkms schalkms merged commit f09a0c4 into detekt:master Nov 9, 2020
@schalkms schalkms deleted the refactor_UselessCallOnNotNull branch November 9, 2020 16:21
@arturbosch arturbosch added this to the 1.15.0 milestone Nov 10, 2020
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Nov 10, 2020
arturbosch pushed a commit that referenced this pull request Dec 21, 2020
* Refactor UselessCallOnNotNull

* Move expression to after null check
arturbosch pushed a commit that referenced this pull request Jan 16, 2021
* Refactor UselessCallOnNotNull

* Move expression to after null check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants