Skip to content

Refactor HasPlatformType rule #3210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2020
Merged

Refactor HasPlatformType rule #3210

merged 1 commit into from
Nov 7, 2020

Conversation

schalkms
Copy link
Member

@schalkms schalkms commented Nov 7, 2020

No description provided.

@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #3210 (025d055) into master (7f8ee20) will increase coverage by 0.00%.
The diff coverage is 38.46%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3210   +/-   ##
=========================================
  Coverage     80.07%   80.07%           
- Complexity     2638     2642    +4     
=========================================
  Files           440      440           
  Lines          8019     8020    +1     
  Branches       1540     1539    -1     
=========================================
+ Hits           6421     6422    +1     
  Misses          775      775           
  Partials        823      823           
Impacted Files Coverage Δ Complexity Δ
...ab/arturbosch/detekt/rules/bugs/HasPlatformType.kt 68.00% <38.46%> (-1.57%) 11.00 <6.00> (+1.00) ⬇️
...b/arturbosch/detekt/rules/naming/FunctionNaming.kt 91.30% <0.00%> (-0.37%) 12.00% <0.00%> (+1.00%) ⬇️
...ekt/rules/style/optional/PreferToOverPairSyntax.kt 80.00% <0.00%> (+1.42%) 5.00% <0.00%> (+1.00%)
...rturbosch/detekt/rules/bugs/RedundantElseInWhen.kt 70.58% <0.00%> (+3.92%) 7.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f8ee20...025d055. Read the comment docs.

@schalkms schalkms merged commit 6fc4609 into detekt:master Nov 7, 2020
@schalkms schalkms deleted the refactor_HasPlatformType branch November 7, 2020 22:33
sowmyav24 pushed a commit to sowmyav24/detekt that referenced this pull request Nov 8, 2020
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Nov 10, 2020
@arturbosch arturbosch added this to the 1.15.0 milestone Nov 10, 2020
arturbosch pushed a commit that referenced this pull request Dec 21, 2020
arturbosch pushed a commit that referenced this pull request Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants