Refactor UnsafeCallOnNullableType rule - #3221
Merged
schalkms merged 1 commit intoNov 10, 2020
Merged
Conversation
t-kameyama
commented
Nov 10, 2020
Contributor
- Check KtPostfixExpression instead of KtUnaryExpression
- We don't need to check KtPrefixExpression
- Check nullability after checking if operation is '!!'
- We don't need to check nullability if operation is not '!!'
Codecov Report
@@ Coverage Diff @@
## master #3221 +/- ##
============================================
+ Coverage 80.06% 80.09% +0.02%
- Complexity 2645 2651 +6
============================================
Files 440 440
Lines 8012 8013 +1
Branches 1535 1529 -6
============================================
+ Hits 6415 6418 +3
Misses 775 775
+ Partials 822 820 -2
Continue to review full report at Codecov.
|
BraisGabin
approved these changes
Nov 10, 2020
schalkms
approved these changes
Nov 10, 2020
arturbosch
pushed a commit
that referenced
this pull request
Dec 21, 2020
arturbosch
pushed a commit
that referenced
this pull request
Jan 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.