Simplify EqualsOnSignatureLine rule#3224
Merged
schalkms merged 1 commit intoNov 12, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3224 +/- ##
============================================
- Coverage 80.09% 80.08% -0.02%
- Complexity 2647 2648 +1
============================================
Files 440 440
Lines 8010 8010
Branches 1529 1528 -1
============================================
- Hits 6416 6415 -1
Misses 775 775
- Partials 819 820 +1
Continue to review full report at Codecov.
|
BraisGabin
approved these changes
Nov 11, 2020
schalkms
reviewed
Nov 11, 2020
schalkms
left a comment
schalkms
left a comment
Member
There was a problem hiding this comment.
Thanks for this PR!
I’m not sure whether those changes really simplify the rule. Could you please elaborate why? The codecov report shows an increase in complexity of a very small margin.
t-kameyama
commented
Nov 11, 2020
| val afterParams = function.valueParameterList?.siblings(forward = true, withItself = false) ?: return | ||
|
|
||
| // Collect tokens until we find the equals sign | ||
| val untilEquals = afterParams.takeWhile { it !== equals }.toList() |
Contributor
Author
There was a problem hiding this comment.
toList() is useless. It should be processed as Sequence.
Member
|
Thanks for the explanation. Let’s see what others think about the change. |
arturbosch
pushed a commit
that referenced
this pull request
Dec 21, 2020
arturbosch
pushed a commit
that referenced
this pull request
Jan 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.