-
-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation page on type resolution #3225
Add documentation page on type resolution #3225
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3225 +/- ##
============================================
- Coverage 80.10% 80.06% -0.05%
- Complexity 2647 2649 +2
============================================
Files 440 443 +3
Lines 8013 8072 +59
Branches 1529 1535 +6
============================================
+ Hits 6419 6463 +44
- Misses 775 789 +14
- Partials 819 820 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition!
Co-authored-by: Brais Gabín <braisgabin@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review. I completely missed this PR.
Anyways, I really appreciate your work on this. This is great stuff. 👏
I have only some minor comments (typos, grammar).
Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com>
Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com>
* Add documentation page on type resolution Fixes #2259 * Update docs/pages/gettingstarted/type-resolution.md Co-authored-by: Brais Gabín <braisgabin@gmail.com> * Apply suggestions from code review Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com> * Add note on lintWithContext Co-authored-by: Brais Gabín <braisgabin@gmail.com> Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com>
* Add documentation page on type resolution Fixes #2259 * Update docs/pages/gettingstarted/type-resolution.md Co-authored-by: Brais Gabín <braisgabin@gmail.com> * Apply suggestions from code review Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com> * Add note on lintWithContext Co-authored-by: Brais Gabín <braisgabin@gmail.com> Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com>
I'm adding a page to explain in detail what is type resolution, how to enable it, how to write a custom rule that uses it and how to test it 👌
We had an empty page on the website for too long :) To start filling it.
This page is more like a draft. Happy to collect and integrated feedbacks.
Fixes #2259