Add documentation page on type resolution#3225
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3225 +/- ##
============================================
- Coverage 80.10% 80.06% -0.05%
- Complexity 2647 2649 +2
============================================
Files 440 443 +3
Lines 8013 8072 +59
Branches 1529 1535 +6
============================================
+ Hits 6419 6463 +44
- Misses 775 789 +14
- Partials 819 820 +1
Continue to review full report at Codecov.
|
BraisGabin
approved these changes
Nov 17, 2020
Co-authored-by: Brais Gabín <braisgabin@gmail.com>
schalkms
approved these changes
Nov 17, 2020
Member
schalkms
left a comment
There was a problem hiding this comment.
Sorry for the late review. I completely missed this PR.
Anyways, I really appreciate your work on this. This is great stuff. 👏
I have only some minor comments (typos, grammar).
Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com>
Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com>
arturbosch
pushed a commit
that referenced
this pull request
Dec 21, 2020
* Add documentation page on type resolution Fixes #2259 * Update docs/pages/gettingstarted/type-resolution.md Co-authored-by: Brais Gabín <braisgabin@gmail.com> * Apply suggestions from code review Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com> * Add note on lintWithContext Co-authored-by: Brais Gabín <braisgabin@gmail.com> Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com>
arturbosch
pushed a commit
that referenced
this pull request
Jan 16, 2021
* Add documentation page on type resolution Fixes #2259 * Update docs/pages/gettingstarted/type-resolution.md Co-authored-by: Brais Gabín <braisgabin@gmail.com> * Apply suggestions from code review Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com> * Add note on lintWithContext Co-authored-by: Brais Gabín <braisgabin@gmail.com> Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm adding a page to explain in detail what is type resolution, how to enable it, how to write a custom rule that uses it and how to test it 👌
We had an empty page on the website for too long :) To start filling it.
This page is more like a draft. Happy to collect and integrated feedbacks.
Fixes #2259