Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude detekt:LargeClass rule in test sources #3237

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Exclude detekt:LargeClass rule in test sources #3237

merged 1 commit into from
Nov 17, 2020

Conversation

schalkms
Copy link
Member

No description provided.

@detekt detekt deleted a comment from codecov bot Nov 16, 2020
BraisGabin
BraisGabin approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have this change in all my projects too. Would it have sense to add this change to the default config?

@schalkms
Copy link
Member Author

I have this change in all my projects too. Would it have sense to add this change to the default config?

I think this heavily depends on the project setup and the used test framework. In general I would wait for more requests and feedback from the community. If they share the same opinion, we can for sure go this way. At the moment, I’d leave it as it is, since it’s a sensible default.

@schalkms schalkms merged commit 439cbb8 into detekt:master Nov 17, 2020
@schalkms schalkms deleted the test-exclude_LargeClass branch November 17, 2020 11:03
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Nov 17, 2020
@arturbosch arturbosch added this to the 1.15.0 milestone Nov 17, 2020
arturbosch pushed a commit that referenced this pull request Dec 21, 2020
@schalkms @arturbosch
Exclude detekt:LargeClass rule in test sources (#3237)
df60ec9
arturbosch pushed a commit that referenced this pull request Jan 16, 2021
@schalkms @arturbosch
Exclude detekt:LargeClass rule in test sources (#3237)
db83db1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

Assignees
No one assigned
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@schalkms @BraisGabin @arturbosch