Simplify ReturnFromFinally check for finally expressions#3276
Merged
Conversation
The BindingContext does not need to checked twice whether it is empty. Visiting both the try block and corresponding finally block is unnecessary, because the try block can navigate to the finally block.
Codecov Report
@@ Coverage Diff @@
## master #3276 +/- ##
=========================================
Coverage 80.07% 80.08%
+ Complexity 2653 2652 -1
=========================================
Files 443 443
Lines 8096 8094 -2
Branches 1540 1540
=========================================
- Hits 6483 6482 -1
Misses 789 789
+ Partials 824 823 -1
Continue to review full report at Codecov.
|
arturbosch
approved these changes
Dec 11, 2020
BraisGabin
approved these changes
Dec 12, 2020
arturbosch
pushed a commit
that referenced
this pull request
Dec 21, 2020
The BindingContext does not need to be checked twice whether it is empty. Visiting both the try block and corresponding finally block is unnecessary, because the try block can navigate to the finally block.
arturbosch
pushed a commit
that referenced
this pull request
Jan 16, 2021
The BindingContext does not need to be checked twice whether it is empty. Visiting both the try block and corresponding finally block is unnecessary, because the try block can navigate to the finally block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BindingContext does not need to be checked twice whether it is empty.
Visiting both the try block and corresponding finally block is unnecessary,
because the try block can navigate to the finally block.