Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline ReturnFromFinally report message text #3277

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Inline ReturnFromFinally report message text #3277

merged 1 commit into from
Dec 11, 2020

Conversation

schalkms
Copy link
Member

@schalkms schalkms commented Dec 11, 2020

There is no special need for a separate const value here.

There is no special for a separate const value here.
@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #3277 (0dafcf4) into master (fc5c993) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3277      +/-   ##
============================================
+ Coverage     80.07%   80.09%   +0.02%     
+ Complexity     2653     2652       -1     
============================================
  Files           443      443              
  Lines          8096     8095       -1     
  Branches       1540     1539       -1     
============================================
+ Hits           6483     6484       +1     
  Misses          789      789              
+ Partials        824      822       -2     
Impacted Files Coverage Δ Complexity Δ
...bosch/detekt/rules/exceptions/ReturnFromFinally.kt 85.71% <100.00%> (+6.40%) 9.00 <0.00> (-1.00) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc5c993...dcab92d. Read the comment docs.

@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Dec 11, 2020
@arturbosch arturbosch added this to the 1.15.0 milestone Dec 11, 2020
@arturbosch arturbosch merged commit 8a51941 into detekt:master Dec 11, 2020
arturbosch pushed a commit that referenced this pull request Dec 21, 2020
There is no special for a separate const value here.
arturbosch pushed a commit that referenced this pull request Jan 16, 2021
There is no special for a separate const value here.
@schalkms schalkms deleted the Refactor_ReturnFromFinally2 branch March 13, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants