NamedArguments: fix false positive with java method call#3290
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3290 +/- ##
============================================
- Coverage 80.05% 80.02% -0.03%
- Complexity 2663 2667 +4
============================================
Files 443 443
Lines 8111 8126 +15
Branches 1539 1542 +3
============================================
+ Hits 6493 6503 +10
- Misses 795 796 +1
- Partials 823 827 +4
Continue to review full report at Codecov.
|
fb5b49d to
4d8a255
Compare
|
Are we OK about removing features of detekt without type solving? Or do we want to keep the mixed rules? I prefer no mix. |
I'm fine with this change. I believe we should push users to use Type Resolution + restrict the rules with mixed behavior (#2994). This rule is going to become a Type Resolution only so it 👍 on my end. |
…etekt/rules/complexity/NamedArgumentsSpec.kt
|
I agree. This shouldn't be a mixed rule. |
* NamedArguments: fix false positive with java method call * Update detekt-rules-complexity/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/NamedArgumentsSpec.kt Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com>
Fixes #3289