Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General housekeeping #3298

Merged
merged 4 commits into from
Dec 24, 2020
Merged

General housekeeping #3298

merged 4 commits into from
Dec 24, 2020

Conversation

chao2zhang
Copy link
Member

@chao2zhang chao2zhang commented Dec 19, 2020

Please let me know if this type of PR is preferred. I tend to move minor refactoring into a separate PR when making fairly large changes.

  • Refactor more config keys as key companion object
  • Convert some KDocs from using # into using []
  • Remove self-recursive function in Context
  • Fix correct dokka task name in CONTRIBUTING.md

- Refactor more config keys as key companion object
- Convert some KDocs from using # into using []
- Remove self-recursive function in Context
- Fix correct dokka task name in CONTRIBUTING.md
@codecov
Copy link

codecov bot commented Dec 19, 2020

Codecov Report

Merging #3298 (64336b2) into master (37f0a1d) will increase coverage by 0.00%.
The diff coverage is 46.15%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3298   +/-   ##
=========================================
  Coverage     80.02%   80.03%           
  Complexity     2673     2673           
=========================================
  Files           443      443           
  Lines          8130     8129    -1     
  Branches       1545     1545           
=========================================
  Hits           6506     6506           
+ Misses          796      795    -1     
  Partials        828      828           
Impacted Files Coverage Δ Complexity Δ
...n/kotlin/io/gitlab/arturbosch/detekt/api/Config.kt 100.00% <ø> (ø) 0.00 <0.00> (ø)
...ain/kotlin/io/gitlab/arturbosch/detekt/api/Rule.kt 100.00% <ø> (ø) 15.00 <0.00> (ø)
...ch/detekt/core/config/DisabledAutoCorrectConfig.kt 44.44% <0.00%> (ø) 5.00 <0.00> (ø)
...ab/arturbosch/detekt/core/config/FailFastConfig.kt 36.36% <0.00%> (ø) 5.00 <0.00> (ø)
...ab/arturbosch/detekt/core/config/IssueExtension.kt 87.50% <ø> (ø) 0.00 <0.00> (ø)
.../kotlin/io/gitlab/arturbosch/detekt/api/Context.kt 63.63% <25.00%> (+5.30%) 0.00 <0.00> (ø)
...lin/io/gitlab/arturbosch/detekt/api/ConfigAware.kt 66.66% <100.00%> (ø) 0.00 <0.00> (ø)
...lab/arturbosch/detekt/core/config/MaxIssueCheck.kt 94.11% <100.00%> (ø) 13.00 <0.00> (ø)
...ekt/generator/printer/rulesetpage/ConfigPrinter.kt 76.08% <100.00%> (ø) 9.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37f0a1d...64336b2. Read the comment docs.

Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! These PRs are more than welcome. Please check my comments.

…onfig/IssueExtension.kt

Co-authored-by: Brais Gabín <braisgabin@gmail.com>
@schalkms schalkms merged commit 0d6ac64 into detekt:master Dec 24, 2020
@chao2zhang chao2zhang deleted the housekeeping branch December 24, 2020 17:39
arturbosch pushed a commit that referenced this pull request Jan 16, 2021
* General housekeeping

- Refactor more config keys as key companion object
- Convert some KDocs from using # into using []
- Remove self-recursive function in Context
- Fix correct dokka task name in CONTRIBUTING.md

* Revert change on Context.report

* Remove MAX_ISSUES_KEY back to IssueExtension

* Update detekt-core/src/main/kotlin/io/gitlab/arturbosch/detekt/core/config/IssueExtension.kt

Co-authored-by: Brais Gabín <braisgabin@gmail.com>

Co-authored-by: Brais Gabín <braisgabin@gmail.com>
@arturbosch arturbosch added this to the 1.16.0 milestone Jan 18, 2021
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants