-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General housekeeping #3298
General housekeeping #3298
Conversation
- Refactor more config keys as key companion object - Convert some KDocs from using # into using [] - Remove self-recursive function in Context - Fix correct dokka task name in CONTRIBUTING.md
Codecov Report
@@ Coverage Diff @@
## master #3298 +/- ##
=========================================
Coverage 80.02% 80.03%
Complexity 2673 2673
=========================================
Files 443 443
Lines 8130 8129 -1
Branches 1545 1545
=========================================
Hits 6506 6506
+ Misses 796 795 -1
Partials 828 828
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! These PRs are more than welcome. Please check my comments.
detekt-api/src/main/kotlin/io/gitlab/arturbosch/detekt/api/Config.kt
Outdated
Show resolved
Hide resolved
detekt-core/src/main/kotlin/io/gitlab/arturbosch/detekt/core/config/IssueExtension.kt
Outdated
Show resolved
Hide resolved
…onfig/IssueExtension.kt Co-authored-by: Brais Gabín <braisgabin@gmail.com>
* General housekeeping - Refactor more config keys as key companion object - Convert some KDocs from using # into using [] - Remove self-recursive function in Context - Fix correct dokka task name in CONTRIBUTING.md * Revert change on Context.report * Remove MAX_ISSUES_KEY back to IssueExtension * Update detekt-core/src/main/kotlin/io/gitlab/arturbosch/detekt/core/config/IssueExtension.kt Co-authored-by: Brais Gabín <braisgabin@gmail.com> Co-authored-by: Brais Gabín <braisgabin@gmail.com>
Please let me know if this type of PR is preferred. I tend to move minor refactoring into a separate PR when making fairly large changes.