Remove exceptions of Library rules - #3304
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3304 +/- ##
=========================================
Coverage 80.32% 80.33%
+ Complexity 2721 2712 -9
=========================================
Files 445 445
Lines 8168 8171 +3
Branches 1553 1553
=========================================
+ Hits 6561 6564 +3
Misses 774 774
Partials 833 833
Continue to review full report at Codecov.
|
| @@ -554,6 +554,7 @@ style: | |||
| methods: ['kotlin.io.println', 'kotlin.io.print'] | |||
| ForbiddenPublicDataClass: | |||
| active: false | |||
There was a problem hiding this comment.
Maybe we should activate all three rules. With the exclude filter set by default nothing gets flagged, so this is fine.
There was a problem hiding this comment.
I activated them as you said but I'm not sure about this. This are rules only for library developers. Even if we exclude all the files it seems like rules that should be disabled by default.
There was a problem hiding this comment.
Let's see what the community thinks about it.
|
@BraisGabin sorry for my late review. This PR went under my radar, unfortunately. |
schalkms
left a comment
There was a problem hiding this comment.
All questions are solved. Thanks! PR looks good to me.
|
Closes #3279 |
arturbosch
left a comment
There was a problem hiding this comment.
Should be clearer for the user, good thoughts!
* Fix typo * exclude all files in our library rules by default * Active ForbiddenPublicDataClass and LibraryEntitiesShouldNotBePublic by default
We had this code to make our 3 library rules behave different. But our users don't understand that #3215.
With this PR I change those rules to behave as any other rule but changing their default configuration so the users can see what's going on.
This is an alternative implementation of #3279
I did disable the rule LibraryCodeMustSpecifyReturnType by default too.