Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure default excludes for InvalidPackageDeclaration #3305

Merged
merged 2 commits into from
Dec 21, 2020
Merged

Configure default excludes for InvalidPackageDeclaration #3305

merged 2 commits into from
Dec 21, 2020

Conversation

schalkms
Copy link
Member

Closes #2539

@codecov
Copy link

codecov bot commented Dec 19, 2020 •
edited
Loading

Codecov Report

Merging #3305 (23d16d0) into master (43c7159) will increase coverage by 0.01%.
The diff coverage is 76.47%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3305      +/-   ##
============================================
+ Coverage     80.02%   80.03%   +0.01%     
+ Complexity     2673     2669       -4     
============================================
  Files           443      443              
  Lines          8130     8140      +10     
  Branches       1545     1548       +3     
============================================
+ Hits           6506     6515       +9     
  Misses          796      796              
- Partials        828      829       +1
Impacted Files Coverage Δ Complexity Δ
...ekt/generator/printer/rulesetpage/ConfigPrinter.kt 75.00% <50.00%> (-1.09%) 9.00 <0.00> (ø)
.../detekt/generator/printer/rulesetpage/Exclusion.kt 95.83% <90.90%> (ø) 0.00 <0.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43c7159...23d16d0. Read the comment docs.

@schalkms
Adapt to generator to output .kts
23d16d0 
* Refactor the generator to support different excludes
* Each rule and rule set can only have one exclude pattern
@schalkms schalkms merged commit 75ce32e into master Dec 21, 2020
@schalkms schalkms deleted the schalkms-#2539-InvalidPackageDeclaration branch December 21, 2020 18:57
@arturbosch arturbosch added this to the 1.16.0 milestone Dec 21, 2020
arturbosch pushed a commit that referenced this pull request Jan 16, 2021
@schalkms @arturbosch
Configure default excludes for InvalidPackageDeclaration (#3305)
ccf731c 
* Configure default excludes for InvalidPackageDeclaration

Closes #2539

* Adapt to generator to output .kts

* Refactor the generator to support different excludes
* Each rule and rule set can only have one exclude pattern
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

Configure default excludes for InvalidPackageDeclaration
3 participants
@schalkms @BraisGabin @arturbosch